Feature 92 ci ignore gpu tests #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeipollack
force-pushed
the
feature_92_ci_ignore_gpu_tests
branch
from
5291236
to
146725f
Compare
|
A comment: I began working on this in the very late hours last Friday. I made some stupid errors bc I was tired. So, I decided to do a hard reset to get rid of the many useless commits. |
jeipollack
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies a fix raised in #92 regarding skipped validation tests. We want the validation tests to be skipped during CI, but to be ran manually with
pytestby the developer. We applied the conditionalpytest.mark.skipifdecorator and will check if the CI environment variable was defined. If yes, the test is skipped, else the test is run.Closes #92