cli/reportgen

Cyfrin · Aug 12, 2024 · f7ea7cb · f7ea7cb
1 parent 73487b8
commit f7ea7cb
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 39 deletions.
diff --git a/reports/report.json b/reports/report.json
@@ -1,7 +1,7 @@
 {
   "files_summary": {
     "total_source_units": 80,
-    "total_sloc": 2521
+    "total_sloc": 2509
   },
   "files_details": {
     "files_details": [
@@ -119,7 +119,7 @@
       },
       {
         "file_path": "src/IncorrectERC721.sol",
-        "n_sloc": 243
+        "n_sloc": 231
       },
       {
         "file_path": "src/IncorrectShift.sol",
@@ -1327,9 +1327,9 @@
           },
           {
             "contract_path": "src/IncorrectERC721.sol",
-            "line_no": 156,
-            "src": "4353:11",
-            "src_char": "4353:11"
+            "line_no": 147,
+            "src": "4076:11",
+            "src_char": "4076:11"
           },
           {
             "contract_path": "src/PublicVariableReadInExternalContext.sol",
@@ -2053,12 +2053,6 @@
             "line_no": 71,
             "src": "2086:16",
             "src_char": "2086:16"
-          },
-          {
-            "contract_path": "src/IncorrectERC721.sol",
-            "line_no": 103,
-            "src": "3000:17",
-            "src_char": "3000:17"
           }
         ]
       }
@@ -3000,9 +2994,9 @@
           },
           {
             "contract_path": "src/IncorrectERC721.sol",
-            "line_no": 121,
-            "src": "3399:115",
-            "src_char": "3399:115"
+            "line_no": 112,
+            "src": "3122:115",
+            "src_char": "3122:115"
           },
           {
             "contract_path": "src/TestERC20.sol",

diff --git a/reports/report.md b/reports/report.md
@@ -82,7 +82,7 @@ This report was generated by [Aderyn](https://github.com/Cyfrin/aderyn), a stati
 | Key | Value |
 | --- | --- |
 | .sol Files | 80 |
-| Total nSLOC | 2521 |
+| Total nSLOC | 2509 |
 
 
 ## Files Details
@@ -117,7 +117,7 @@ This report was generated by [Aderyn](https://github.com/Cyfrin/aderyn), a stati
 | src/HugeConstants.sol | 36 |
 | src/InconsistentUints.sol | 17 |
 | src/IncorrectCaretOperator.sol | 16 |
-| src/IncorrectERC721.sol | 243 |
+| src/IncorrectERC721.sol | 231 |
 | src/IncorrectShift.sol | 17 |
 | src/InternalFunctions.sol | 22 |
 | src/KeccakContract.sol | 21 |
@@ -169,7 +169,7 @@ This report was generated by [Aderyn](https://github.com/Cyfrin/aderyn), a stati
 | src/reused_contract_name/ContractB.sol | 7 |
 | src/uniswap/UniswapV2Swapper.sol | 50 |
 | src/uniswap/UniswapV3Swapper.sol | 150 |
-| **Total** | **2521** |
+| **Total** | **2509** |
 
 
 ## Issue Summary
@@ -1238,7 +1238,7 @@ Solidity does initialize variables by default when you declare them, however it'
 	    uint256 private s_first;
 	```
 
-- Found in src/IncorrectERC721.sol [Line: 156](../tests/contract-playground/src/IncorrectERC721.sol#L156)
+- Found in src/IncorrectERC721.sol [Line: 147](../tests/contract-playground/src/IncorrectERC721.sol#L147)
 
 	```solidity
 	    uint256 public totalSupply;
@@ -2000,7 +2000,7 @@ It appears that the contract includes a payable function to accept Ether but lac
 
 Incorrect return values for ERC721 functions. A contract compiled with Solidity > 0.4.22 interacting with these functions will fail to execute them, as the return value is missing. Set the appropriate return values and types for the defined ERC721 functions.
 
-<details><summary>9 Found Instances</summary>
+<details><summary>8 Found Instances</summary>
 
 
 - Found in src/IncorrectERC721.sol [Line: 14](../tests/contract-playground/src/IncorrectERC721.sol#L14)
@@ -2051,12 +2051,6 @@ Incorrect return values for ERC721 functions. A contract compiled with Solidity
 	    function safeTransferFrom(
 	```
 
-- Found in src/IncorrectERC721.sol [Line: 103](../tests/contract-playground/src/IncorrectERC721.sol#L103)
-
-	```solidity
-	    function supportsInterface(
-	```
-
 </details>
 
 
@@ -3024,7 +3018,7 @@ Index event fields make the field more quickly accessible to off-chain tools tha
 	    event Transferred(address indexed to, uint256 amount);
 	```
 
-- Found in src/IncorrectERC721.sol [Line: 121](../tests/contract-playground/src/IncorrectERC721.sol#L121)
+- Found in src/IncorrectERC721.sol [Line: 112](../tests/contract-playground/src/IncorrectERC721.sol#L112)
 
 	```solidity
 	    event ApprovalForAll(

diff --git a/reports/report.sarif b/reports/report.sarif
@@ -1766,7 +1766,7 @@
                 },
                 "region": {
                   "byteLength": 11,
-                  "byteOffset": 4353
+                  "byteOffset": 4076
                 }
               }
             },
@@ -3014,17 +3014,6 @@
                   "byteOffset": 2086
                 }
               }
-            },
-            {
-              "physicalLocation": {
-                "artifactLocation": {
-                  "uri": "src/IncorrectERC721.sol"
-                },
-                "region": {
-                  "byteLength": 17,
-                  "byteOffset": 3000
-                }
-              }
             }
           ],
           "message": {
@@ -4707,7 +4696,7 @@
                 },
                 "region": {
                   "byteLength": 115,
-                  "byteOffset": 3399
+                  "byteOffset": 3122
                 }
               }
             },