CPDNPQ-1188: Update only synced application with ecf #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javier-npq
requested review from
Lockyy,
leoapost,
peteryates,
BroiSatse and
slawosz
as code owners
|
Created review app at https://npq-registration-review-app-837.london.cloudapps.digital |
slawosz
reviewed
Jul 12, 2023
| if application.present? | ||
| application.update!(lead_provider_approval_status:, participant_outcome_state:) | ||
| else | ||
| Rails.logger.info("Application #{id} is not synced yet") |
There was a problem hiding this comment.
Maybe Rails.logger.info("Application where ecf_id=#{id} is not synced yet")
slawosz
approved these changes
Jul 12, 2023
javier-npq
deleted the
CPDNPQ-1188-update-only-synced-application-with-ecf
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
update only synced applications with ecf
Ticket/PR:
#819
Changes proposed in this pull request
We are not raising an exception, we will be updating any ID's that are present in the npq space.