Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space Charge Solver #162

Merged
merged 10 commits into from
Sep 20, 2022
Merged

Space Charge Solver #162

merged 10 commits into from
Sep 20, 2022

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Jul 16, 2022

Implement the space charge solver.
Close #101

Update Evolve Loop for Leap-Frog

Loop over elements in the lattice
     Loop over steps through element
          Loop over all particles to apply element map half-step
          Z-to-T transformation
                Solve Poisson equation
          T-to-Z transformation
          Loop over all particles to apply space charge full step
          Loop over all particles to apply element half-step
     End loop over steps through element
End loop over elements

@ax3l ax3l added the component: space charge Space charge & potential solver label Jul 16, 2022
@ax3l ax3l requested review from RemiLehe and cemitch99 July 16, 2022 01:39
@ax3l ax3l mentioned this pull request Jul 19, 2022
2 tasks
@ax3l ax3l requested a review from n01r August 10, 2022 22:30
examples/kurth/input_kurth.in Outdated Show resolved Hide resolved
@ax3l ax3l force-pushed the topic-spacecharge branch 4 times, most recently from f462501 to 1b433fd Compare August 23, 2022 20:54
@ax3l ax3l force-pushed the topic-spacecharge branch 3 times, most recently from 5a44717 to 507b2fe Compare August 31, 2022 22:33
@ax3l ax3l force-pushed the topic-spacecharge branch 4 times, most recently from 248c7f2 to acd2b1e Compare September 16, 2022 01:42
@ax3l ax3l changed the title [WIP] Space Charge Solver Space Charge Solver Sep 19, 2022
@ax3l
Copy link
Member Author

ax3l commented Sep 19, 2022

@cemitch99 @RemiLehe this PR is ready for review & merge.

All other open points in the PR description will be done in follow-up PRs, to keep the lines in this PR small and quick to review.

// scalar potential
auto const phi_nodal_flag = rho_nodal_flag;
int const num_components_phi = 1;
int const num_guards_phi = num_guards_rho + 1; // todo: I think this just depends on max(MLMG, force calc)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RemiLehe let's discuss this again, this might currently be too large (can be performance-optimized in a follow-up PR as well)

Copy link
Member

@cemitch99 cemitch99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me; I don't see any obvious problems. Thanks a lot.

@ax3l ax3l merged commit 4b6b3c7 into ECP-WarpX:development Sep 20, 2022
@ax3l ax3l deleted the topic-spacecharge branch September 20, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: space charge Space charge & potential solver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Space-Charge Solver
3 participants