Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed editing of story #104

Closed
wants to merge 5 commits into from

Conversation

kailash360
Copy link
Member

Issue Number

fixes #97

Describe the changes you've made

Removed story.Description state from the editDescription state as stated in the issue

Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)

NA

Additional context (OPTIONAL)

Test plan (OPTIONAL)

A good test plan should give instructions that someone else can easily follow.

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • The title of my pull request is a short description of the requested changes.

Provide a Deployed link of route/page that needs to review

Preview: Deploy preview link here with the appropriate route

EOS.User.story.-.Google.Chrome.2021-12-12.02-37-42.mp4

@mharshita
Copy link
Member

hey, @kailash360
As decided here, edit functionality was designed in a way that users can only add the information and cannot change it.
A possible fix that you can work on is to introduce a button to unpublish/delete a story instead of making changes to the edit button.

@kailash360
Copy link
Member Author

kailash360 commented Dec 14, 2021

Closing this due to some discrepancies. PR #108 has been made in replacement of this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit Story Feature not working properly
2 participants