Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update temperatures in TUV-x before calculating rate constants #138

Merged
merged 13 commits into from
Oct 25, 2024

Conversation

boulderdaze
Copy link
Collaborator

@boulderdaze boulderdaze commented Oct 17, 2024

Originator(s): @boulderdaze

Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number):

Describe any changes made to the namelist: N/A

List all files eliminated and why: N/A

List all files added and what they do:

  • A schemes/musica/tuvx/musica_ccpp_tuvx_temperature.F90
  • A test/musica/tuvx/test_tuvx_temperature.F90

List all existing files that have been modified, and describe the changes:

  • M schemes/musica/musica_ccpp.F90
  • M schemes/musica/musica_ccpp.meta
  • M schemes/musica/tuvx/musica_ccpp_tuvx.F90
  • M test/musica/CMakeLists.txt
  • M test/musica/test_musica_api.F90
  • M test/musica/tuvx/CMakeLists.txt
  • M test/musica/tuvx/configs/ts1_tsmlt.json
  • M test/valgrind.supp

List any test failures: N/A

Is this a science-changing update? New physics package, algorithm change, tuning changes, etc? No

@boulderdaze boulderdaze self-assigned this Oct 17, 2024
@boulderdaze boulderdaze marked this pull request as ready for review October 23, 2024 23:46
Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

Copy link
Member

@jimmielin jimmielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This looks good, I just had a few minor questions about the code and some assumptions regarding the vertical grid from the host model.

Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@boulderdaze boulderdaze merged commit 9955b6d into development Oct 25, 2024
2 checks passed
@boulderdaze boulderdaze deleted the 95-update-tuvx-temp branch October 25, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants