Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support starting transaction in EvseManager #573

Merged

Conversation

golovasteek
Copy link
Contributor

@golovasteek golovasteek commented Mar 3, 2024

resolves #572

The solution presented here is suitable for basic use-case under German Measurement law.

Prior to starting charging on BSP, the EvseManager will request meter to start transaction.
Starting the transaction on the power meter is expected to return quicly (by either spawning some process in the meter driver, or initiating the transaction on the meter hardware).

The signed meter values for start transaction are not expected to be reported by the meter when transaction is requested.

There are different meter models, and signed meter values for transaction start, may be a separate "SignedMeterValue" object. in this case the start_signed_meter_value of "StopTransactionResponse" can be used. And the signed_meter_value would contain data for the session finish.

In many cases the meter only issue one signed dataset for session, that contains multiple snapshots encoded, in this case only signed_meter_value is used.

What is not covered by this PR:

  • OCPP module as well as libOCPP need to be adjusted, to use "start_signed_meter_value" from TransactionFinished event
  • the meter values for the transaction are only transferred at the end of the session, there is no support for asynchronous sending of meter values introduced. Which needs to be designed spearately, once we have better requiremetns from the OCPP of different versions.

@golovasteek golovasteek force-pushed the support_transactions_in_evse_manager branch 2 times, most recently from 004c055 to df5c3f3 Compare March 3, 2024 09:07
@golovasteek golovasteek marked this pull request as ready for review March 4, 2024 18:02
@dorezyuk dorezyuk mentioned this pull request Mar 7, 2024
1 task
@golovasteek golovasteek marked this pull request as draft March 14, 2024 16:32
@golovasteek golovasteek force-pushed the support_transactions_in_evse_manager branch 7 times, most recently from 4839bf4 to f187a9c Compare March 20, 2024 10:15
@golovasteek golovasteek marked this pull request as ready for review March 20, 2024 14:27
cmake/everest-generate.cmake Outdated Show resolved Hide resolved
modules/EvseManager/Charger.cpp Outdated Show resolved Hide resolved
modules/EvseManager/Charger.cpp Outdated Show resolved Hide resolved
modules/EvseManager/Charger.cpp Show resolved Hide resolved
@corneliusclaussen corneliusclaussen added the include-in-release Tag that this PR should be included in the current merge window for the upcoming release if possible label Mar 22, 2024
@golovasteek golovasteek force-pushed the support_transactions_in_evse_manager branch 3 times, most recently from 2d1eea2 to 3b49e5b Compare March 25, 2024 13:18
@golovasteek golovasteek force-pushed the support_transactions_in_evse_manager branch from 3b49e5b to a31fa0b Compare March 25, 2024 13:40
@golovasteek golovasteek force-pushed the support_transactions_in_evse_manager branch from 072a3d1 to 8054615 Compare April 2, 2024 15:46
@corneliusclaussen
Copy link
Contributor

Next time if you change something during review, please do not squash commits. It is very hard to follow your changes and see if they are resolved now. The best way is to squash before opening the PR, then stack commits with changes during review on it and finally squash again as needed during the merging.

@golovasteek
Copy link
Contributor Author

Next time if you change something during review, please do not squash commits. It is very hard to follow your changes and see if they are resolved now. The best way is to squash before opening the PR, then stack commits with changes during review on it and finally squash again as needed during the merging.

Makes sense.
Will do this way.

@golovasteek golovasteek force-pushed the support_transactions_in_evse_manager branch from 8054615 to 1459a7f Compare April 2, 2024 16:23
Co-authored-by: Dima Dorezyuk <[email protected]>
Signed-off-by: Evgeny Petrov <[email protected]>
@golovasteek golovasteek force-pushed the support_transactions_in_evse_manager branch from 1459a7f to 2678338 Compare April 3, 2024 10:47
@Pietfried Pietfried self-assigned this Apr 4, 2024
@Pietfried Pietfried merged commit 70d1136 into EVerest:main Apr 4, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include-in-release Tag that this PR should be included in the current merge window for the upcoming release if possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support signed meter in EvseManager/Charger
4 participants