-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support starting transaction in EvseManager #573
Support starting transaction in EvseManager #573
Conversation
004c055
to
df5c3f3
Compare
4839bf4
to
f187a9c
Compare
2d1eea2
to
3b49e5b
Compare
3b49e5b
to
a31fa0b
Compare
072a3d1
to
8054615
Compare
Next time if you change something during review, please do not squash commits. It is very hard to follow your changes and see if they are resolved now. The best way is to squash before opening the PR, then stack commits with changes during review on it and finally squash again as needed during the merging. |
Makes sense. |
8054615
to
1459a7f
Compare
Co-authored-by: Dima Dorezyuk <[email protected]> Signed-off-by: Evgeny Petrov <[email protected]>
1459a7f
to
2678338
Compare
resolves #572
The solution presented here is suitable for basic use-case under German Measurement law.
Prior to starting charging on BSP, the EvseManager will request meter to start transaction.
Starting the transaction on the power meter is expected to return quicly (by either spawning some process in the meter driver, or initiating the transaction on the meter hardware).
The signed meter values for start transaction are not expected to be reported by the meter when transaction is requested.
There are different meter models, and signed meter values for transaction start, may be a separate "SignedMeterValue" object. in this case the
start_signed_meter_value
of "StopTransactionResponse" can be used. And thesigned_meter_value
would contain data for the session finish.In many cases the meter only issue one signed dataset for session, that contains multiple snapshots encoded, in this case only
signed_meter_value
is used.What is not covered by this PR:
TransactionFinished
event