Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul ColumnFileReader #82

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

NebelNidas
Copy link
Collaborator

@NebelNidas NebelNidas commented Nov 18, 2023

  • Adds stacked mark support.
  • Removes some weird inconsistencies where nextCol("") would return false even though nextCol() would return exactly that string. Now consistently returns null when encountering or already being at EOL, and an empty string when the column or line is empty.
  • Tries to properly mark EOF too alongside EOL, preventing situations where the reader gets stuck at EOL at the end of the file but never toggles EOF to true.
  • Adds peek support (reading without consuming, kinda like nextCol(String) already worked when the string didn't match).
  • Adds support for custom indentation characters.
  • Improves documentation.

@modmuss50 modmuss50 added this to the 0.6.0 milestone Nov 21, 2023
@NebelNidas NebelNidas modified the milestones: 0.6.0, 0.7.0 Dec 14, 2023
@NebelNidas NebelNidas force-pushed the ColumnFileReader-overhaul branch 2 times, most recently from 4f46225 to c1ce391 Compare April 12, 2024 15:13
@NebelNidas NebelNidas marked this pull request as ready for review April 12, 2024 15:14
@modmuss50 modmuss50 merged commit 36c52a5 into FabricMC:dev Apr 17, 2024
3 checks passed
@NebelNidas NebelNidas deleted the ColumnFileReader-overhaul branch August 28, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants