fix: allow reusing call instances after leaving #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myandrienko
commented
Jul 4, 2024
|
|
||
| this.dispatcher.offAll(); |
There was a problem hiding this comment.
🍓 Not removing listeners from dispatcher.
That seems to be safe, since every object keeping a reference to a dispatcher (except for the call itself) is nullified on leave. So the call instance will be GC-ed properly even without offAll.
| this.camera = new CameraManager(this); | ||
| this.microphone = new MicrophoneManager(this); | ||
| this.speaker = new SpeakerManager(this); | ||
| this.screenShare = new ScreenShareManager(this); | ||
| } | ||
|
|
||
| private async setup() { | ||
| await withoutConcurrency(this.joinLeaveConcurrencyTag, async () => { |
There was a problem hiding this comment.
Prevents a race condition with leave. It's important to wait for leave to finish before we set everything back up again. See the test case here: https://github.com/GetStream/stream-video-js/pull/1433/files#diff-912706ed8d680e55d746f9765aa5090d64771196a9894262bed3e0b73d9a8c97R92-R110
oliverlaz
approved these changes
Jul 24, 2024
myandrienko
added a commit
that referenced
this pull request
Jul 25, 2024
🚂 #1433 Removes a guard preventing joining left calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.