-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix-for-pyuvdat2.4 #266
Fix-for-pyuvdat2.4 #266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine, but I think we should deal with the weird commented-out bits before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks @steven-murray!
This cropped up due to a change in the default parameters in the hera_cal function that is called.
Phasing information arrays are now updated at the end of the time interpolation routine, though this is only supported for unprojected data.
Fix adjustment issues
…to fix-for-pyuvdat2.4
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
==========================================
- Coverage 92.95% 92.89% -0.07%
==========================================
Files 24 24
Lines 3209 3222 +13
Branches 705 706 +1
==========================================
+ Hits 2983 2993 +10
- Misses 123 126 +3
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Updates API calls for pyuvdata to be able to use v2.4.0.