Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-for-pyuvdat2.4 #266

Merged
merged 12 commits into from
Aug 17, 2023
Merged

Fix-for-pyuvdat2.4 #266

merged 12 commits into from
Aug 17, 2023

Conversation

steven-murray
Copy link
Contributor

Updates API calls for pyuvdata to be able to use v2.4.0.

@steven-murray steven-murray self-assigned this Aug 1, 2023
Copy link
Contributor

@r-pascua r-pascua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but I think we should deal with the weird commented-out bits before merging.

hera_sim/sigchain.py Outdated Show resolved Hide resolved
hera_sim/sigchain.py Outdated Show resolved Hide resolved
Copy link
Contributor

@r-pascua r-pascua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks @steven-murray!

r-pascua and others added 5 commits August 11, 2023 12:46
This cropped up due to a change in the default parameters in the
hera_cal function that is called.
Phasing information arrays are now updated at the end of the time
interpolation routine, though this is only supported for unprojected
data.
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 95.23% and project coverage change: -0.07% ⚠️

Comparison is base (208932a) 92.95% compared to head (cbea744) 92.89%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
- Coverage   92.95%   92.89%   -0.07%     
==========================================
  Files          24       24              
  Lines        3209     3222      +13     
  Branches      705      706       +1     
==========================================
+ Hits         2983     2993      +10     
- Misses        123      126       +3     
  Partials      103      103              
Flag Coverage Δ
unittests 92.86% <95.23%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
hera_sim/io.py 93.05% <0.00%> (-2.72%) ⬇️
hera_sim/sigchain.py 92.82% <ø> (-0.28%) ⬇️
hera_sim/visibilities/cli.py 92.96% <ø> (ø)
hera_sim/adjustment.py 99.50% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@steven-murray steven-murray merged commit f45653e into main Aug 17, 2023
7 of 8 checks passed
@steven-murray steven-murray deleted the fix-for-pyuvdat2.4 branch August 17, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants