Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix-for-pyuvdat2.4 #266

Merged
merged 12 commits into from
Aug 17, 2023
Merged

Fix-for-pyuvdat2.4 #266

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a61c0f5
fix: update API calls for pyuvdata>=2.4.0
steven-murray Aug 1, 2023
67874ed
docs: update changelog
steven-murray Aug 1, 2023
a1260db
chore: remove comments
steven-murray Aug 8, 2023
7d24113
test: fix tests to call SkyModel with frame arg
steven-murray Aug 10, 2023
4079c5f
test: fix tests to call SkyModel with frame arg
steven-murray Aug 10, 2023
af0c6f5
fix: bug in rephasing function
r-pascua Aug 11, 2023
9b8e4d3
fix: time interpolation issues
r-pascua Aug 14, 2023
f43fb15
Merge pull request #269 from HERA-Team/fix_adjustment_issues
steven-murray Aug 15, 2023
d476fec
fix: add frame kwarg to test
steven-murray Aug 17, 2023
5390f8e
Merge branch 'fix-for-pyuvdat2.4' of github.com:HERA-Team/hera_sim in…
steven-murray Aug 17, 2023
e0252b9
ci: use sphinx<7.2 temporarily
steven-murray Aug 17, 2023
cbea744
test: whether appropriate value error is raised when cat_type!=unproj…
steven-murray Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@
Changelog
=========

dev
===

Fixed
-----
- API calls for pyuvdata v2.4.0.

v4.1.0 [2023.06.26]
===================
This release heavily focuses on performance of the visibility simulators, and in
Expand Down
2 changes: 1 addition & 1 deletion hera_sim/io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def empty_uvdata(
# This is a bit of a hack, but this seems like the only way?
if pyuvdata.__version__ < "2.2.0":
uvd.set_drift()
else:
elif next(iter(uvd.phase_center_catalog.values()))["cat_type"] != "unprojected":
uvd.fix_phase()

# TODO: the following is a hack patch for pyuvsim which should be fixed there.
Expand Down
9 changes: 6 additions & 3 deletions hera_sim/sigchain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1086,12 +1086,15 @@ def build_coupling_matrix(
else:
power_beam = uvbeam.copy()
power_beam.efield_to_power()
if power_beam.interpolation_function is None:
power_beam.interpolation_function = pixel_interp
# if power_beam.interpolation_function is None:
# power_beam.interpolation_function = pixel_interp
steven-murray marked this conversation as resolved.
Show resolved Hide resolved
if power_beam.freq_interp_kind is None:
power_beam.freq_interp_kind = freq_interp
power_beam = power_beam.interp(
freq_array=freqs * units.GHz.to("Hz"), new_object=True
freq_array=freqs * units.GHz.to("Hz"),
new_object=True,
interpolation_function=pixel_interp,
# freq_interp_func=freq_interp,
steven-murray marked this conversation as resolved.
Show resolved Hide resolved
) # Interpolate to the desired frequencies
power_beam.to_healpix()
power_beam.peak_normalize()
Expand Down
2 changes: 2 additions & 0 deletions hera_sim/visibilities/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,8 @@ def run_vis_sim(args):
lst_range=None,
polarizations=None,
blt_inds=None,
phase_center_ids=None,
catalog_names=None,
)[0]

np.save(args.compress, blt_inds)
Expand Down
Loading