Fix metadata logging even when actors crash #721
Merged
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated. In case the ray actors crash, the key `processing_time` may not be updated to stats, so while rounding off this key, we may get an exception which stops metadata from being written. Signed-off-by: Shivdeep Singh <[email protected]>
daw3rd
requested changes
Oct 17, 2024
data-processing-lib/ray/src/data_processing_ray/runtime/ray/transform_orchestrator.py
Show resolved
Hide resolved
Merged
daw3rd
approved these changes
Oct 28, 2024
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In case the ray actors crash, the key
processing_timemay not be updated to stats, so while rounding off this key, we may get an exception which stops metadata from being written.Related issue number (if any).
Also seen in the crash here. #719