Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): use alert only for custom provider error #1991

Closed
wants to merge 1 commit into from
Closed

feat(client): use alert only for custom provider error #1991

wants to merge 1 commit into from

Conversation

daniellacosse
Copy link
Contributor

No description provided.

@daniellacosse daniellacosse requested a review from a team as a code owner April 22, 2024 21:08
@daniellacosse daniellacosse mentioned this pull request Apr 22, 2024
Merged
sbruens
sbruens approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@sbruens sbruens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what @fortuna had in mind, but this LGTM.

fortuna
fortuna requested changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@fortuna fortuna left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, what is the experience here? Are we not showing the error toast anymore?

fortuna
fortuna reviewed Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diverges from the usual error handling. Why not show the regular toast, with details?

fortuna
fortuna requested changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are you showing the details?
I meant in the other PR to show the toast with the message, as we do with all errors, but the details on the alert.

@daniellacosse
Copy link
Contributor Author

How are you showing the details? I meant in the other PR to show the toast with the message, as we do with all errors, but the details on the alert.

Let's get aligned when you're back, I'm super confused now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fortuna fortuna fortuna requested changes

@sbruens sbruens sbruens approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daniellacosse @fortuna @sbruens