Fix watchlist error via compat #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #47 +/- ##
===========================================
+ Coverage 57.25% 87.65% +30.39%
===========================================
Files 1 1
Lines 124 81 -43
===========================================
Hits 71 71
+ Misses 53 10 -43 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #46. This patch should hopefully ensure that no updated Julia instances will run the outdated MLJXGBoostInterface code against XGBoost version 2.5.0.
As a side-note, I expected
XGBoost = "2.0.1"to go only to <2.1.0, but that's apparently not true. EDIT: Oh wait. That makes sense. Normally a2.4to2.5should not be breaking, but in this case it was. Anyway, let's just fix it and be done with it.