Sqlite test #7
Sqlite test #7
Conversation
fixing the file path issue by identifying its type to String - testing it(Passed)
There was a problem hiding this comment.
Hi @Farreeda ,
Thank you so much for working on this issue! I left some comments for improving the test suite here and some feedback.
Let me know if you have any questions!
.vscode/extensions.json
Outdated
There was a problem hiding this comment.
Could you remove this file from this PR? It should not be here but was autogenerated by VSCode. Feel free to update the .gitignore file to ignore all things generated from VSCode.
.vscode/settings.json
Outdated
There was a problem hiding this comment.
Could you remove this file from this PR? It should not be here but was autogenerated by VSCode. Feel free to update the .gitignore file to ignore all things generated from VSCode.
There was a problem hiding this comment.
The reason why this PR's test are failing right now is due to the fact that _dbconnect is trying to access the DB file but the DB file is not being sourced properly from the test environment. You will have to add in the db file to the test environment, like test/data/sqlite_test.db and then have the test environment find the file.
This is also why you got the error email is that I enabled the test suite to run and GitHub sent you an email to say that the test suite failed.
Let me know if you have any questions -- good start! :)
There was a problem hiding this comment.
It is updated, thank you for your patience :D
removed .vscode folder added
test/runtests.jl
Outdated
| @test hello("Julia") == "Hello, Julia" | ||
| @test domath(2.0) ≈ 7.0 |
There was a problem hiding this comment.
Could you remove this?
test/runtests.jl
Outdated
|
|
||
| @testset "_dbconnect function for SQLite" begin | ||
|
|
||
| conn= _dbconnect(SQLite.DB, "DBConnector.jl/test/data/database.db") |
There was a problem hiding this comment.
Small think but could you rename "database.db" to "sqlite.db"?
| @testset "_dbconnect function for SQLite" begin | ||
|
|
||
| conn= _dbconnect(SQLite.DB, "DBConnector.jl/test/data/database.db") | ||
| @test @isdefined conn |
There was a problem hiding this comment.
I think this is a good test but could you also write a test that:
- Queries the database
- Reports a result
- Verifies that the result returns what is expected
Fixing the file_path issue and testing the _dbconnect function for SQLite only
issue #3 & issue #6