-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sqlite test #7
base: dev
Are you sure you want to change the base?
Sqlite test #7
Changes from 5 commits
526ca48
9ea3bd1
ccb0995
9f01623
8c81230
120f262
031dc3c
d5091ee
fa48076
2760adc
f6e27db
535ff8b
0e92556
766149a
43b80c5
6152c9d
106173a
967e798
421f10d
5eadd8e
2d1ed6c
fc02a02
fdef69c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
function _dbconnect(connector::Type{SQLite.DB}; file_path) | ||
function _dbconnect(connector::Type{SQLite.DB}, file_path::String) | ||
|
||
return connector(file_path.second) | ||
return connector(file_path) | ||
|
||
end |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,3 +2,10 @@ using Test, Example | |
|
||
@test hello("Julia") == "Hello, Julia" | ||
@test domath(2.0) ≈ 7.0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you remove this? |
||
|
||
@testset "_dbconnect function for SQLite" begin | ||
|
||
conn= _dbconnect(SQLite.DB, "DBConnector.jl/test/data/database.db") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Small think but could you rename "database.db" to "sqlite.db"? |
||
@test @isdefined conn | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is a good test but could you also write a test that:
|
||
|
||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason why this PR's test are failing right now is due to the fact that
_dbconnect
is trying to access the DB file but the DB file is not being sourced properly from the test environment. You will have to add in the db file to the test environment, liketest/data/sqlite_test.db
and then have the test environment find the file.This is also why you got the error email is that I enabled the test suite to run and GitHub sent you an email to say that the test suite failed.
Let me know if you have any questions -- good start! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is updated, thank you for your patience :D