Implemented changes based on PR review

LiskHQ · May 15, 2024 · 66e64ef · 66e64ef
1 parent c2caf4e
commit 66e64ef
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 8 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -8,7 +8,7 @@
     "PRODUCTION": true,
     "LISK_DOMAIN": true,
     "REACT_APP_DEFAULT_NETWORK": true,
-    "REACT_APP_MAPBOX_ACCESS_TOKEN": true,
+    "REACT_APP_MAPBOX_ACCESS_TOKEN": true
   },
   "env": {
     "es2020": true,

diff --git a/.gitignore b/.gitignore
@@ -15,10 +15,13 @@ app/app.js
 blockchain_explorer.db.gz
 reports
 .history
-.env.*
 yarn-error.log
 *.tgz
 
+## Local environment files
+.env.*
+!.env.example
+
 ## Commercial fonts
 setup/react/assets/fonts/basierCircle/
 setup/react/assets/fonts/gilroy/

diff --git a/Jenkinsfile b/Jenkinsfile
@@ -8,7 +8,7 @@ pipeline {
 		ansiColor('xterm')
 	}
 	parameters {
-		string(name: 'CORE_VERSION', defaultValue: '4.0.2')
+		string(name: 'CORE_VERSION', defaultValue: '4.0.5')
 		string(name: 'SERVICE_BRANCH_NAME', defaultValue: 'development')
 	}
 	stages {

diff --git a/libs/hardwareWallet/ledger/ledgerLiskAppIPCChannel/serverLedgerHWCommunication/index.js b/libs/hardwareWallet/ledger/ledgerLiskAppIPCChannel/serverLedgerHWCommunication/index.js
@@ -10,6 +10,8 @@ const isHexString = (data) => {
   return data === '' || /^([0-9a-f]{2})+$/i.test(data);
 };
 
+const NO_ERRORS = 'No errors';
+
 export async function getPubKey({ devicePath, accountIndex, showOnDevice }) {
   let transport;
   try {
@@ -20,7 +22,7 @@ export async function getPubKey({ devicePath, accountIndex, showOnDevice }) {
       ? await liskLedger.showAddressAndPubKey(ledgerAccount.derivePath())
       : await liskLedger.getAddressAndPubKey(ledgerAccount.derivePath());
     await transport?.close();
-    if (response?.error_message === 'No errors') {
+    if (response?.error_message === NO_ERRORS) {
       return response?.pubKey;
     }
     return Promise.reject(response.return_code);
@@ -37,7 +39,7 @@ export async function getMultipleAddresses({ devicePath, accountIndexes }) {
     const liskLedger = new LiskApp(transport);
     const response = await liskLedger.getMultipleAddresses(accountIndexes);
     await transport?.close();
-    if (response?.error_message === 'No errors') {
+    if (response?.error_message === NO_ERRORS) {
       return response?.addr;
     }
     return Promise.reject(response.return_code);
@@ -58,7 +60,7 @@ export async function getSignedTransaction({ devicePath, accountIndex, unsignedM
       Buffer.from(unsignedMessage, 'hex')
     );
     if (transport && transport.close) await transport.close();
-    if (response?.error_message === 'No errors') {
+    if (response?.error_message === NO_ERRORS) {
       return response;
     }
     return Promise.reject(response.return_code);
@@ -80,7 +82,7 @@ export async function getSignedMessage({ devicePath, accountIndex, unsignedMessa
     const response = await liskLedger.signMessage(ledgerAccount.derivePath(), message);
     await transport?.close();
 
-    if (response?.error_message === 'No errors') {
+    if (response?.error_message === NO_ERRORS) {
       return response;
     }
     return Promise.reject(response.return_code);
@@ -102,7 +104,7 @@ export async function getSignedRawMessage({ devicePath, accountIndex, unsignedMe
     const response = await liskLedger.claimMessage(ledgerAccount.derivePath(), message);
     await transport?.close();
 
-    if (response?.error_message === 'No errors') {
+    if (response?.error_message === NO_ERRORS) {
       return response;
     }
     return Promise.reject(response.return_code);