Skip to content

Commit

Permalink
Update mac build method
Browse files Browse the repository at this point in the history
  • Loading branch information
shuse2 committed May 19, 2024
1 parent 3331d78 commit 83bc5e3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 14 deletions.
16 changes: 5 additions & 11 deletions .github/workflows/electron-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ name: 'electron-build'

on:
push:
branches:
- fix-deployment
tags:
- v3.*

Expand Down Expand Up @@ -51,13 +53,6 @@ jobs:
if: startsWith(matrix.os, 'desktop-build')
run: npm install -g cpx

- name: Prepare for app notarization
if: startsWith(matrix.os, 'macos')
# Import Apple API key for app notarization on macOS
run: |
mkdir -p ~/private_keys/
echo "${{ secrets.api_key_new }}" > ~/private_keys/AuthKey_${{ secrets.api_key_id_new }}.p8
- name: Build and pack windows app
if: startsWith(matrix.os, 'desktop-build')
# codesigning
Expand All @@ -76,10 +71,9 @@ jobs:
github_token: ${{ secrets.github_token }}
env:
# macOS for notarization API key
API_KEY: ${{ secrets.api_key_new }}
API_KEY_ID: ${{ secrets.api_key_id_new }}
API_KEY_ISSUER_ID: ${{ secrets.api_key_issuer_id }}
APPLE_TEAM_ID: ${{ secrets.apple_team_id }}
APPLE_ID: ${{ secrets.APPLE_ID }}
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}

- name: Output Notarization Error Log
if: failure() && startsWith(matrix.os, 'macos')
Expand Down
4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,7 @@
"gatekeeperAssess": false,
"entitlements": "build/entitlements.plist",
"entitlementsInherit": "build/entitlements.plist",
"notarize": {
"teamId": "${APPLE_TEAM_ID}"
},
"notarize": true,
"target": {
"target": "default",
"arch": [
Expand Down

0 comments on commit 83bc5e3

Please sign in to comment.