Added font download stage in github actions #5405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ManuGowda
changed the title
eniolam1000752
approved these changes
Oct 26, 2023
ManuGowda
reviewed
Oct 26, 2023
ManuGowda
reviewed
Oct 26, 2023
ManuGowda
approved these changes
Oct 26, 2023
Nazgolze
approved these changes
Oct 26, 2023
ManuGowda
merged commit 9c27dcd
into
1977-setup-electron-builder-actions
2 of 6 checks passed
|
Congrats on merging your first pull request! Ready for new challenges? You can find your next issue here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Unable to download fonts on local directory - Closes #5406
How was it solved?
Uploaded in private s3 bucket. Downloading all fonts from s3 bucket using AWS credential.
How was it tested?
Tested on our local system.