Add port forwarding support and bump to 2.2.0 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Split out interface detection into intf-exists? function. - Use 'intf-exists?' to check for 'eth0' (docker host bridge interface) and store result in ctx :docker-eth0? property. - Some minor docs/formating changes.
jonsmock
reviewed
Apr 19, 2024
jonsmock
approved these changes
Apr 19, 2024
The function that runs a docker-compose commmand becomes dc_run and that's all it does (not wait loop). The main test running function that includes the retry functionality is split out into a non-compose specific function called do_test. If the WITH_DC environment variable is set then it uses dc_run to run a command, otherwise it invokes the arguments in a regular shell call. The dc_wait and dc_test function become trivial wrappers around do_test.
Allow the minimum ping delay over the netem link to be anywhere from 80ms - 85ms instead of 80ms.
- Add new 'forward' link property. This property is an array of strings of the form `conlink_port:container_port/proto` similar to docker port publishing. - Add 'link-forward.sh' script that will add (or delete) the iptables and route rules to accomplish the port forwarding from one interface to an IP on another interface with port remappping (NAT/masquerade). - Add a test10 example that shows a single forward definition forwarding to two container replicas and shows two forward defintions both forwarding to a single container service/port.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add port forwarding support (conlink -> containers)
of the form
conlink_port:container_port/protosimilar to docker portpublishing.
and route rules to accomplish the port forwarding from one interface
to an IP on another interface with port remappping (NAT/masquerade).
to two container replicas and shows two forward defintions both
forwarding to a single container service/port.
Also, small refactor in how docker's eth0 interface is detected and renamed (to support port forwarding) and some refactor to run-tests.sh to support tests invocations that are compose exec calls (i.e. curl from the outside to support port forwarding tests).