Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to use es imports consistently, create global MapML namespace for element interfaces. #1003

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Refactor to use es imports consistently, create global MapML namespace for element interfaces. #1003

merged 2 commits into from
Oct 30, 2024

Commits on Oct 30, 2024

  1. Use nodeResolve() in rollup to import node_modules by name 

    Refactor / remove global L.symbol use to use
imported symbol of same name from "leaflet" import.

Update module specifiers to include ".js" where it is a file
in this project for consistency.

Update package.json to use specific forks of
proj4leaflet (module version), leaflet-locatecontrol (module version)

Get import of proj4leaflet from specific branch of maps4html/proj4leaflet
fork, which may never get merged upstream, but keeps differences in a
git repo, at least, instead of in the build script.

Update some tests to import the leaflet module directly

Create window.L.GridLayer, .L.DomUtil so that protomaps-leaflet will work.

Add rollup alias plugin to allow rollup to resove import of 'leaflet' to
correct file (Leaflet lacks a "module" key as of 1.9.4). This
allows us to not have to modify what's in node_modules.

Get import of proj4 from the module code that ships with that project.
The maps4html/proj4leaflet fork works with proj4 code as shipped.

Update "module","main" keys with correct path
relative to dist/ subdirectory

Use npm-installed esm version of leaflet-locatecontrol
    @prushforth
    prushforth committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    f079ac6 View commit details
    Browse the repository at this point in the history

  2. Make touchDevice.test.js pass on CI/linux by ignoring leaflet layer 

    control class, testing _isExpanded property only.  Force touch device
emulation by changing how context is launched, options passed.
    @prushforth
    prushforth committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    5e76162 View commit details
    Browse the repository at this point in the history