Refactor to use es imports consistently, create global MapML namespace for element interfaces. #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prushforth
force-pushed
the
es6-modularization
branch
4 times, most recently
from
7c9f417
to
81d3922
Compare
Refactor / remove global L.symbol use to use imported symbol of same name from "leaflet" import. Update module specifiers to include ".js" where it is a file in this project for consistency. Update package.json to use specific forks of proj4leaflet (module version), leaflet-locatecontrol (module version) Get import of proj4leaflet from specific branch of maps4html/proj4leaflet fork, which may never get merged upstream, but keeps differences in a git repo, at least, instead of in the build script. Update some tests to import the leaflet module directly Create window.L.GridLayer, .L.DomUtil so that protomaps-leaflet will work. Add rollup alias plugin to allow rollup to resove import of 'leaflet' to correct file (Leaflet lacks a "module" key as of 1.9.4). This allows us to not have to modify what's in node_modules. Get import of proj4 from the module code that ships with that project. The maps4html/proj4leaflet fork works with proj4 code as shipped. Update "module","main" keys with correct path relative to dist/ subdirectory Use npm-installed esm version of leaflet-locatecontrol
control class, testing _isExpanded property only. Force touch device emulation by changing how context is launched, options passed.
prushforth
force-pushed
the
es6-modularization
branch
from
e2d15ae
to
5e76162
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use nodeResolve() in rollup to import node_modules by name
Refactor global L.symbol use to use imported symbol of same name from "leaflet" import.
Update module specifiers to include ".js" where it is a file for consistency.
Update package.json to use specific forks of
proj4leaflet (module version), leaflet-locatecontrol (module version)
Get import of proj4leaflet from specific branch of maps4html/proj4leaflet fork, which may never get merged upstream, but keeps differences in a git repo, at least, instead of in the build script.
Update some tests to import the leaflet module directly
Create window.L so that protomaps-leaflet will work.
Add rollup alias plugin to allow rollup to resove import of 'leaflet' to correct file (Leaflet lacks a "module" key as of 1.9.4)
Get import of proj4 from the module code that ships with that project. The maps4html/proj4leaflet fork works with proj4 code as shipped.