Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth-json-rpc-provider migration - B3: Align dependencies with monorepo. #1766

Merged
merged 9 commits into from
Oct 5, 2023

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Oct 3, 2023

Explanation

This PR implements the following incremental step in the process for migrating eth-json-rpc-provider into the core monorepo:


Phase B: Staging in migrated-packages/

3. Align dependencies with monorepo.

  • Remove redundant dependencies that are already listed in the root package.json.
  • Bump remaining dependency versions so that they align with other non-root packages.

See #1551 (comment) for an outline of the entire process.

References

Changelog

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@socket-security
Copy link

socket-security bot commented Oct 3, 2023

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/jest 28.1.8...28.1.7 None +0/-0 73.2 kB types
typedoc 0.23.28...0.23.15 None +0/-1 1.02 MB typedoc-bot

🚮 Removed packages: [email protected], [email protected]

@MajorLift MajorLift added enhancement New feature or request dependencies Pull requests that update a dependency file team-wallet-framework labels Oct 3, 2023
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MajorLift MajorLift merged commit 4b8f6ee into main Oct 5, 2023
107 checks passed
@MajorLift MajorLift deleted the 231003-migrate-eth-json-rpc-provider-b3 branch October 5, 2023 20:33
MajorLift added a commit that referenced this pull request Oct 12, 2023
…epo. (#1766)

## Explanation

This PR implements the following incremental step in the process for
migrating `eth-json-rpc-provider` into the core monorepo:

***

### Phase B: Staging in `migrated-packages/`
#### 3. Align dependencies with monorepo.
- [x] Remove redundant dependencies that are already listed in the root
package.json.
- [x] Bump remaining dependency versions so that they align with other
non-root packages.

***

See #1551 (comment)
for an outline of the entire process.

## References

- Contributes to #1685
- Contributes to #1551

## Changelog

N/A

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants