Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for Node.js versions 16, 21 #109

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 3, 2024

  • Drop support for Node.js versions 16, 21
  • Add Node.js v22 to CI matrix
  • ci: yarn --ignore-engines to work around out of date eslint-plugin-jsdoc

Related

Blocking

Copy link

socket-security bot commented Oct 3, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] None 0 487 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 1.89 MB nicolo-ribaudo
npm/@types/[email protected] None 0 2.02 MB types
npm/[email protected] None 0 73.1 kB ethan_arrowood

🚮 Removed packages: npm/@babel/[email protected], npm/@babel/[email protected], npm/@types/[email protected]

View full report↗︎

Resolves:

 error [email protected]: The engine "node" is incompatible with this module. Expected version "^14 || ^16 || ^17 || ^18 || ^19 || ^20". Got "22.9.0"

ignore-engines is default behavior in newer yarn versions.
@legobeat legobeat merged commit 08c725b into MetaMask:main Oct 14, 2024
8 checks passed
@legobeat legobeat deleted the node-18 branch October 14, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants