Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Update hdkey version #135

Closed
wants to merge 1 commit into from
Closed

Update hdkey version #135

wants to merge 1 commit into from

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Jan 20, 2022

The need to update this package was identified (a long time ago) while investigating this issue MetaMask/metamask-extension#6012

@danjm danjm requested a review from a team as a code owner January 20, 2022 14:11
@aloisklink
Copy link

Hi @danjm, sorry if this is a dumb question, but is there any reason why the latest version of hdkey: ^2.0.1 shouldn't be used?

I'm asking since I noticed that eth-trezor-keyring is also using the old 0.8.0 version of hdkey: MetaMask/eth-trezor-keyring#117 (comment)

hdkey "^2.0.1" is already in metamask-extensions' yarn.lock-file as @KeystoneHQ uses it, so using v2 would be more more space efficient and more secure.

darkwing
darkwing suggested changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally clicked approve.

We should try to update to ^2.0.1 as was suggested.

@legobeat legobeat mentioned this pull request Oct 3, 2023
Merged
@legobeat
Copy link
Contributor

legobeat commented Oct 3, 2023 •
edited
Loading

@legobeat
Copy link
Contributor

Closing in favor of #196

@legobeat legobeat closed this Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@darkwing darkwing darkwing requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danjm @aloisklink @legobeat @darkwing