Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

deps: [email protected]>^2.1.0 #196

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 3, 2023

  • bump hdkey from 0.8.0 to ^2.1.0

Supersedes

Related

@legobeat legobeat marked this pull request as ready for review October 3, 2023 04:22
@legobeat legobeat requested a review from a team as a code owner October 3, 2023 04:22
@socket-security
Copy link

socket-security bot commented Oct 3, 2023

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
hdkey 0.8.0...2.1.0 None +0/-8 15.3 kB ryanzim

@legobeat legobeat requested review from a team October 3, 2023 04:27
@adonesky1
Copy link
Contributor

adonesky1 commented Oct 4, 2023

It appears the only breaking change is bumping required node version to 10 and this package already requires > v14. Have you verified that there are no other adaptations required @legobeat ?

@legobeat
Copy link
Contributor Author

legobeat commented Oct 4, 2023

It appears the only breaking change is bumping required node version to 10 and this package already requires > v14. Have you verified that there are no other adaptations required @legobeat ?

Should be good. The other potentially breaking change in the package would be cryptocoinjs/hdkey#20, where this package already consistently uses a basePath of m/.

@legobeat legobeat merged commit d587771 into MetaMask:main Oct 25, 2023
19 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants