chore: storybook clean up #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-41
to
-44
| '@components': path.resolve( | ||
| __dirname, | ||
| '../packages/react-components/src', | ||
| ), |
There was a problem hiding this comment.
Storybook seems to be working without this and it was before we agreed on the names of the packages so it's a little out of date
| @@ -1,14 +1,6 @@ | |||
| // import path from 'path'; | |||
| import react from '@vitejs/plugin-react'; | |||
There was a problem hiding this comment.
Updates vite config to be aligned with react https://github.com/vitejs/vite-plugin-react/tree/main/packages/plugin-react#vitejsplugin-react-
Comment on lines
-6
to
-12
| // TO DO: Update when react component package is created | ||
| // alias: { | ||
| // '@components': path.resolve( | ||
| // __dirname, | ||
| // '../packages/react-components/src', | ||
| // ), | ||
| // }, |
There was a problem hiding this comment.
Not needed and out dated
| @@ -24,6 +24,7 @@ | |||
| "@types/prop-types": "^15", | |||
| "@types/react": "^18.2.0", | |||
| "@types/react-dom": "^18.2.0", | |||
| "@vitejs/plugin-react": "^4.3.3", | |||
There was a problem hiding this comment.
Adding react plugin that is used in vite config
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
brianacnguyen
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Storybook clean up removing some configuration that is no longer needed
Related issues
Fixes: N/A
Manual testing steps
yarn storybookScreenshots/Recordings
After
after720.mov
Pre-merge author checklist
Pre-merge reviewer checklist