Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: storybook clean up #116

Merged
merged 4 commits into from
Nov 15, 2024
Merged

chore: storybook clean up #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
66c20d1
chore: storybook clean up
georgewrmarshall Nov 15, 2024
05190f6
chore: removing dependency for storybook manager
georgewrmarshall Nov 15, 2024
d34e382
chore: updating vite config
georgewrmarshall Nov 15, 2024
3febc01
chore: lint fix
georgewrmarshall Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions apps/storybook-react/.storybook/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@ const config: StorybookConfig = {
__dirname,
'../../../node_modules/@metamask/design-tokens',
),
'@components': path.resolve(
__dirname,
'../packages/react-components/src',
),
Comment on lines -41 to -44
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storybook seems to be working without this and it was before we agreed on the names of the packages so it's a little out of date

};
}
return config;
Expand Down
1 change: 1 addition & 0 deletions apps/storybook-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"@types/prop-types": "^15",
"@types/react": "^18.2.0",
"@types/react-dom": "^18.2.0",
"@vitejs/plugin-react": "^4.3.3",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding react plugin that is used in vite config

"autoprefixer": "^10.4.20",
"prop-types": "^15.8.1",
"react": "^18.2.0",
Expand Down
12 changes: 2 additions & 10 deletions apps/storybook-react/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,6 @@
// import path from 'path';
import react from '@vitejs/plugin-react';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates vite config to be aligned with react https://github.com/vitejs/vite-plugin-react/tree/main/packages/plugin-react#vitejsplugin-react-

import { defineConfig } from 'vite';

export default defineConfig({
resolve: {
// TO DO: Update when react component package is created
// alias: {
// '@components': path.resolve(
// __dirname,
// '../packages/react-components/src',
// ),
// },
Comment on lines -6 to -12
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed and out dated

},
plugins: [react()],
});
31 changes: 27 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ __metadata:
languageName: node
linkType: hard

"@babel/core@npm:^7.1.0, @babel/core@npm:^7.12.10, @babel/core@npm:^7.12.3, @babel/core@npm:^7.13.16, @babel/core@npm:^7.18.9, @babel/core@npm:^7.20.0, @babel/core@npm:^7.23.5, @babel/core@npm:^7.7.2, @babel/core@npm:^7.8.0":
"@babel/core@npm:^7.1.0, @babel/core@npm:^7.12.10, @babel/core@npm:^7.12.3, @babel/core@npm:^7.13.16, @babel/core@npm:^7.18.9, @babel/core@npm:^7.20.0, @babel/core@npm:^7.23.5, @babel/core@npm:^7.25.2, @babel/core@npm:^7.7.2, @babel/core@npm:^7.8.0":
version: 7.26.0
resolution: "@babel/core@npm:7.26.0"
dependencies:
Expand Down Expand Up @@ -1358,7 +1358,7 @@ __metadata:
languageName: node
linkType: hard

"@babel/plugin-transform-react-jsx-self@npm:^7.0.0":
"@babel/plugin-transform-react-jsx-self@npm:^7.0.0, @babel/plugin-transform-react-jsx-self@npm:^7.24.7":
version: 7.25.9
resolution: "@babel/plugin-transform-react-jsx-self@npm:7.25.9"
dependencies:
Expand All @@ -1369,7 +1369,7 @@ __metadata:
languageName: node
linkType: hard

"@babel/plugin-transform-react-jsx-source@npm:^7.0.0":
"@babel/plugin-transform-react-jsx-source@npm:^7.0.0, @babel/plugin-transform-react-jsx-source@npm:^7.24.7":
version: 7.25.9
resolution: "@babel/plugin-transform-react-jsx-source@npm:7.25.9"
dependencies:
Expand Down Expand Up @@ -3422,6 +3422,7 @@ __metadata:
"@types/prop-types": "npm:^15"
"@types/react": "npm:^18.2.0"
"@types/react-dom": "npm:^18.2.0"
"@vitejs/plugin-react": "npm:^4.3.3"
autoprefixer: "npm:^10.4.20"
prop-types: "npm:^15.8.1"
react: "npm:^18.2.0"
Expand Down Expand Up @@ -5273,7 +5274,7 @@ __metadata:
languageName: node
linkType: hard

"@types/babel__core@npm:^7.0.0, @types/babel__core@npm:^7.1.14, @types/babel__core@npm:^7.18.0":
"@types/babel__core@npm:^7.0.0, @types/babel__core@npm:^7.1.14, @types/babel__core@npm:^7.18.0, @types/babel__core@npm:^7.20.5":
version: 7.20.5
resolution: "@types/babel__core@npm:7.20.5"
dependencies:
Expand Down Expand Up @@ -5780,6 +5781,21 @@ __metadata:
languageName: node
linkType: hard

"@vitejs/plugin-react@npm:^4.3.3":
version: 4.3.3
resolution: "@vitejs/plugin-react@npm:4.3.3"
dependencies:
"@babel/core": "npm:^7.25.2"
"@babel/plugin-transform-react-jsx-self": "npm:^7.24.7"
"@babel/plugin-transform-react-jsx-source": "npm:^7.24.7"
"@types/babel__core": "npm:^7.20.5"
react-refresh: "npm:^0.14.2"
peerDependencies:
vite: ^4.2.0 || ^5.0.0
checksum: 10/816b47c54aefce198ce2fb2b3e63b5f158ab33b04713dbec0e780a89c5126d4ea6b08544972464c43096b16e90e7f467fcf19692fad30d4f8ca5bf9a386f38b3
languageName: node
linkType: hard

"@vitest/expect@npm:2.0.5":
version: 2.0.5
resolution: "@vitest/expect@npm:2.0.5"
Expand Down Expand Up @@ -16919,6 +16935,13 @@ __metadata:
languageName: node
linkType: hard

"react-refresh@npm:^0.14.2":
version: 0.14.2
resolution: "react-refresh@npm:0.14.2"
checksum: 10/512abf97271ab8623486061be04b608c39d932e3709f9af1720b41573415fa4993d0009fa5138b6705b60a98f4102f744d4e26c952b14f41a0e455521c6be4cc
languageName: node
linkType: hard

"react-refresh@npm:^0.4.0":
version: 0.4.3
resolution: "react-refresh@npm:0.4.3"
Expand Down
Loading