Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Youtube): Add support for height & width options #151

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

seanmcn
Copy link

@seanmcn seanmcn commented Oct 29, 2020

What: Adds support for passing height & width to the YouTube Transformer.

Why: Makes the transformer more customisable, not everyone wants their videos 100% wide and 315px high? 🤣 Requested by someone else in #144 and is something I require.

How: In the same way as #146

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #151 (41d6b9d) into main (668d719) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 41d6b9d differs from pull request most recent head 816d3b2. Consider uploading reports for the commit 816d3b2 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #151   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        16    -1     
  Lines          300       220   -80     
  Branches        95        29   -66     
=========================================
- Hits           300       220   -80     
Impacted Files Coverage Δ
src/transformers/YouTube.js 100.00% <100.00%> (ø)
src/index.js 100.00% <0.00%> (ø)
src/transformers/GIPHY.js 100.00% <0.00%> (ø)
src/transformers/index.js 100.00% <0.00%> (ø)
src/transformers/Slides.js 100.00% <0.00%> (ø)
src/transformers/Twitch.js 100.00% <0.00%> (ø)
src/transformers/CodePen.js 100.00% <0.00%> (ø)
src/transformers/Lichess.js 100.00% <0.00%> (ø)
src/transformers/Spotify.js 100.00% <0.00%> (ø)
src/transformers/Twitter.js 100.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 668d719...816d3b2. Read the comment docs.

@seanmcn
Copy link
Author

seanmcn commented Oct 29, 2020

TravisCI seems to have failed on npm install for environment Node.js: node. Not sure how my PR could have caused that, I imagine it's unrelated, let me know if I'm incorrect 😄 .

@MichaelDeBoey MichaelDeBoey self-assigned this Oct 29, 2020
@MichaelDeBoey MichaelDeBoey added the ⚙️ YouTube Issue or pull request regarding YouTube label Oct 29, 2020
seanmcn added a commit to seanmcn/my-website that referenced this pull request Oct 31, 2020
seanmcn added a commit to seanmcn/my-website that referenced this pull request Oct 31, 2020
@rlamana
Copy link

rlamana commented Jul 10, 2021

Any news about this PR? I'd really need this feature...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ YouTube Issue or pull request regarding YouTube
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants