-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
516 prep: fix chat window z-fighting and tgui-say escape key #4615
Open
Absolucy
wants to merge
13
commits into
Monkestation:master
Choose a base branch
from
Absolucy:more-516-stuff
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+857
−713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolucy
force-pushed
the
more-516-stuff
branch
from
December 19, 2024 03:22
a2bb281
to
b5bf411
Compare
Port of ParadiseSS13/Paradise#27676, which in turn is a port of VOREStation/VOREStation#16713 and VOREStation/VOREStation#16734
Absolucy
force-pushed
the
more-516-stuff
branch
from
December 19, 2024 23:59
76f7624
to
eada54f
Compare
This was referenced Dec 20, 2024
This was referenced Dec 21, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports the following PRs:
this fixes chat window flicker caused by z-fighting in 516, alongside escape key not working to exit tgui-say. (autofocus still seems to have issues, tho)
Proof of Testing
515:
516:
Why It's Good For The Game
516 beta is coming out REALLY SOON, so we gotta be ready
Changelog
this will be (test)merged by the time 516 is available publicly anyways, no changelog needed as there won't be any visible changes