Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thermal Bridging and Derating #183

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

mdahlhausen
Copy link
Contributor

@mdahlhausen mdahlhausen commented Jun 3, 2024

Pull request overview

This pull requests adds thermal bridging to the baseline ComStock model generation workflow.
Change documentation.

This PR includes changes to the upgrade_env_exterior_wall_insulation and upgrade_env_roof_insul_aedg measures.

Pull Request Author

This pull request makes changes to (select all the apply):

  • Documentation
  • Workflow Measures
  • Upgrade Measures

Author pull request checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Added tests for new measures
  • Updated measure .xml(s)
  • Register values added to comstock_column_definitions.csv
  • Both options_lookup.tsv files updated
  • 10k+ test run
  • Change documentation written
  • Measure documentation written
  • ComStock documentation updated
  • Changes reflected in example .yml files
  • Changes reflected in README.md files
  • Added 'See ComStock License' language to first two lines of each code file
  • Implements corresponding measure tests and indexing path in test/measure_tests.txt or/and test/resource_measure_tests.txt
  • All new and existing tests pass the CI

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: data and method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • Reviewed change documentation
  • Ensured code files contain License reference
  • Results differences are reasonable
  • Make sure the newly added measures has been added with tests and indexed properly
  • CI status: all tests pass

ComStock Licensing Language - Add to Beginning of Each Code File

# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.

@mdahlhausen mdahlhausen added documentation PR improves or adds documentation workflow measure PR improves or adds baseline workflow measures upgrade measure PR improves or adds upgrade measures labels Jun 3, 2024
mdahlhausen and others added 12 commits June 10, 2024 12:41
adjust the wall and roof upgrade measures to account for thermal bridging in the workflow. Remove all hard assigned constructions before adjusting insulation levels, and then reapply thermal bridging and derating after making the changes.
Use the derating option set corresponding to the default wall construction with the most area.
Note that tbd does not edit constructions if they already have tbd in the name
use resetConstruction instead of remove
update to TBD v3.4.2
Change the set_wall_template and set_roof_template measures to change the default exterior surface constructions instead of hard assigning new constructions to each surface
also remove unused Standard.build
@mdahlhausen
Copy link
Contributor Author

@ChristopherCaradonna I made the changes to the EUSS measures, and both are running and producing reasonable results. I've updated the change documentation with grahpics from the EUSS measure test.

@mdahlhausen mdahlhausen changed the base branch from main to develop September 12, 2024 22:21
@mdahlhausen mdahlhausen changed the base branch from develop to main October 18, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation PR improves or adds documentation upgrade measure PR improves or adds upgrade measures workflow measure PR improves or adds baseline workflow measures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants