Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dms exchange and simplify file opens #403

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

mvertens
Copy link
Contributor

@mvertens mvertens commented Sep 16, 2024

Summary:

  • Replace call shr_file_setLogUnit(shrlogunit) with call shr_log_setLogUnit(shrlogunit). This also required the follow change.
  • Remove nfu as a module variables in mod_xc.F90 and replaces all open files as follows (where nfu is now a local variable). This is done extensively in the CESM code base now.
   open (unit=nfu, file =..... ) (old)
   open (newunit=nfu, file = ....) (new)
  • Send dms to the mediator based on a new NUOPC configuration variable flds_dms. CAM will also query this configuration variable and therefore if dms is sent by BLOM it will now be received by CAM and used.
  • Send bromo to the mediator based on a new NUOPC configuration variable flds_bromo. Currently this is simply a place holder for when CAM will be ready to use it.

Testing:

./create_test --xml-category aux_blom_noresm --xml-machine betzy --compare noresm2_5_alpha04_dev1.6.1.5 --baseline-root ~/baselines/blom_develop --generate noresm2_5_alpha06_dev1.x.x.x

  • All non-hamocc cases were bfb but hamocc cases differed. It would be good to generate new baselines when hamocc changes answers.
  • When this PR is accepted it should be tagged and x.x.x above should be replace by the tag values.

@mvertens mvertens added the enhancement New feature or request label Sep 16, 2024
@mvertens mvertens added this to the NorESM2.5 - BLOM/iHAMOCC milestone Sep 16, 2024
Copy link
Contributor

@TomasTorsvik TomasTorsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvertens - looks good from hamocc point of view. Had a few hamocc updates lately that are answer changing.

phy/mod_xc.F90 Outdated
Comment on lines 93 to 94
! line printer unit (stdout) and file unit with default values 6 and
! 12, respectively
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
! line printer unit (stdout) and file unit with default values 6 and
! 12, respectively
! line printer unit (stdout) with default value 6

@mvertens
Copy link
Contributor Author

@matsbn - I'd like to get this update into a new noresm alpha tag that we can use for the next set of simulations. This will require updates to CAM and CMEPS as well. Currently CAM does not use the DMS coming from BLOM and this PR will fix that.

Copy link
Contributor

@matsbn matsbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Standalone seems to work with the CI test, but I have not tested myself with NorESM2.* and MCT. There we obtained the file unit with shr_file_getUnit(), but I assume there will not be any conflict.

@TomasTorsvik
Copy link
Contributor

@mvertens - I see @matsbn approved this PR. Do you plan to merge it yourself? If not, I can merge it now and make the new BLOM tag.

@mvertens
Copy link
Contributor Author

@TomasTorsvik - if you could merge it now and make a new blom tag - that would be great! Thanks!

@TomasTorsvik TomasTorsvik merged commit 3b5a48c into NorESMhub:master Sep 23, 2024
5 checks passed
@TomasTorsvik
Copy link
Contributor

@mvertens - I have created a new tag on the master branch - dev1.6.1.6

@mvertens mvertens deleted the feature/update_dms_exchange branch October 2, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants