-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dms exchange and simplify file opens #403
update dms exchange and simplify file opens #403
Conversation
…nt with rest of noresm components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mvertens - looks good from hamocc point of view. Had a few hamocc updates lately that are answer changing.
phy/mod_xc.F90
Outdated
! line printer unit (stdout) and file unit with default values 6 and | ||
! 12, respectively |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
! line printer unit (stdout) and file unit with default values 6 and | |
! 12, respectively | |
! line printer unit (stdout) with default value 6 |
@matsbn - I'd like to get this update into a new noresm alpha tag that we can use for the next set of simulations. This will require updates to CAM and CMEPS as well. Currently CAM does not use the DMS coming from BLOM and this PR will fix that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Standalone seems to work with the CI test, but I have not tested myself with NorESM2.* and MCT. There we obtained the file unit with shr_file_getUnit(), but I assume there will not be any conflict.
@TomasTorsvik - if you could merge it now and make a new blom tag - that would be great! Thanks! |
@mvertens - I have created a new tag on the |
Summary:
call shr_file_setLogUnit(shrlogunit)
withcall shr_log_setLogUnit(shrlogunit)
. This also required the follow change.flds_dms
. CAM will also query this configuration variable and therefore if dms is sent by BLOM it will now be received by CAM and used.flds_bromo
. Currently this is simply a place holder for when CAM will be ready to use it.Testing:
./create_test --xml-category aux_blom_noresm --xml-machine betzy --compare noresm2_5_alpha04_dev1.6.1.5 --baseline-root ~/baselines/blom_develop --generate noresm2_5_alpha06_dev1.x.x.x