Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][FIX] account_invoice_fixed_discount: Fix Division by zero error #1558

Merged
merged 2 commits into from
May 2, 2024
Merged

[15.0][FIX] account_invoice_fixed_discount: Fix Division by zero error #1558

merged 2 commits into from
May 2, 2024

Conversation

angelmoya
Copy link
Member

No description provided.

@angelmoya
Copy link
Member Author

#1557

@angelmoya
Copy link
Member Author

Remember: fixed discount module is not compatible with triple discount, so you need to uninstal triple discount before test it

JorgeQuinteros
JorgeQuinteros approved these changes Sep 20, 2023
View reviewed changes
Copy link

@JorgeQuinteros JorgeQuinteros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Technical and Functional Review

JGarcia-Panach
JGarcia-Panach approved these changes Sep 20, 2023
View reviewed changes
Copy link

@JGarcia-Panach JGarcia-Panach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

valentincastravete
valentincastravete approved these changes Sep 20, 2023
View reviewed changes
Copy link

@valentincastravete valentincastravete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Technical and Functional Review

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ioans73 ioans73 mentioned this pull request Mar 25, 2024
Merged
@dreispt
Copy link
Member

dreispt commented May 2, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-1558-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 61b3515 into OCA:15.0 May 2, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 61b3515. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JGarcia-Panach JGarcia-Panach JGarcia-Panach approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@JorgeQuinteros JorgeQuinteros JorgeQuinteros approved these changes

@valentincastravete valentincastravete valentincastravete approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@angelmoya @OCA-git-bot @dreispt @JGarcia-Panach @AaronHForgeFlow @JorgeQuinteros @valentincastravete