Include less v3 #7618
Closed
Include less v3 #7618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## master #7618 +/- ##
==========================================
- Coverage 75.73% 75.72% -0.01%
==========================================
Files 659 659
Lines 185740 185740
==========================================
- Hits 140669 140657 -12
- Misses 45071 45083 +12
Flags with carried forward coverage won't be shown. Click here to find out more. |
catenacyber
force-pushed
the
include-less-v3
branch
from
7d7b5c9
to
c53e0fc
Compare
|
Information: QA ran without warnings. Pipeline 8149 |
|
Information: QA ran without warnings. Pipeline 8150 |
catenacyber
force-pushed
the
include-less-v3
branch
from
c53e0fc
to
dc7f061
Compare
Closed
|
Replaced by #7643 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/945
Describe changes:
Still to do : add
cppcleanas part of CI, so that means having a reproducible cleaner scriptI used this patched version myint/cppclean#165
There are still exceptions :
TAILQwith including queue.h (or red and black tree)#define a(x) b(x)where b is in another file cfSpmSearchThe result is less includes from header file to another, nothing is done for C files including a useless header
Modifies #7570 with rebase and dummy commit to check if it passes CI
This PR adds about one hundred lines
#include "detect-engine-build.h"because it is being used in util tests forSigGroupBuildand such... Any thoughts on that ?