Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/945
Describe changes:
I used this patched version myint/cppclean#165
Still to do : add
cppclean
as part of CI, so that means having a reproducible cleaner scriptThere are still 3 missing features in cppclean that produce 6 errors in Suricata :
#define a(x) b(x)
where b is in another file cfSpmSearch
DECODE_EVENT_MAX
FileMatch
inSigTableElmt
usesFile
from util-file.hAfter that, there are no more errors except for rust headers, suricata-common.h and threads.h cf
cppclean src/*.h | grep "does not need to be #included" | grep -v rust | grep -v suricata-common.h | grep -v threads.h
Modifies #7618 with some more include rework in latest commit
This PR adds about one hundred lines
#include "detect-engine-build.h"
because it is being used in util tests forSigGroupBuild
and such... Any thoughts on that ?