Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update masthead illustration #28

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

jesicasusanto
Copy link
Collaborator

@jesicasusanto jesicasusanto commented Jun 26, 2023

This PR resolves issue #17 by updating the masterhead illustration.

@netlify
Copy link

netlify bot commented Jun 26, 2023

Deploy Preview for cosmic-klepon-3c693c ready!

Name Link
🔨 Latest commit 8bb133c
🔍 Latest deploy log https://app.netlify.com/sites/cosmic-klepon-3c693c/deploys/64b881d9735c8200087cc238
😎 Deploy Preview https://deploy-preview-28--cosmic-klepon-3c693c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jesicasusanto
Copy link
Collaborator Author

Ready for review @abrichr Thank you!

@jesicasusanto
Copy link
Collaborator Author

Update :
Before :
image
After :
image

@abrichr
Copy link
Member

abrichr commented Jul 17, 2023

@jesicasusanto upon review it appears that the new logo is a combined .svg file under public/images/new_masthead.svg.

Can you please clarify how you created this file?

To clarify the intention of #17, the idea is to add .svg files for each of the thought bubble, hand, and eyes, and animate them programmatically in javascript.

@jesicasusanto
Copy link
Collaborator Author

@abrichr Previously, I was copying the contents of each svg file and group them into one svg file. Based on your suggestion, I added each svg file and import them as an Image tag in masthead.js 7aad2e0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants