Add conda canary CI job #903
Conversation
.github/workflows/conda_cron.yaml
Outdated
| pull_request: | ||
| branches: | ||
| - main | ||
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
remove this once CI runs
| name: "Run tests" | ||
| run: | | ||
| # note: this only runs the fast tests | ||
| pytest -n auto --pyargs openfe openfecli |
There was a problem hiding this comment.
I'm relying on a normal failure here rather than raising the issue as we do with gufe. The plan will be to hook up Swenson's cron job checker tool.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #903 +/- ##
==========================================
- Coverage 94.16% 92.35% -1.81%
==========================================
Files 134 134
Lines 9786 9786
==========================================
- Hits 9215 9038 -177
- Misses 571 748 +177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@mikemhenry any ideas why the py3.9 package for macos osx-arm64 wouldn't have bundled the test files :/ seems so odd |
|
that is super weird since we are a |
.github/workflows/conda_cron.yaml
Outdated
| - name: "Install openfe + optional deps" | ||
| run: | | ||
| micromamba install openfe pytest -c conda-forge | ||
| python -m pip install pytest-xdist PyGithub |
There was a problem hiding this comment.
o that was just me being silly wanting to do something else
Yeah.. I don't have an osx-arm64 machine to test it out either. |
|
We can drop 3.9 from our testing matrix entirely IMHO https://scientific-python.org/specs/spec-0000/ |
@mikemhenry I agree, but since it's a canary for "what is currently being used", I do like to be a little bit more "what we were intending the release to be applied to". If you have a strong view here I'm happy to change my mind though! |
|
Okay I agree it will be nice to have, and if it starts failing due to things outside of our control, we will then know and can mention that it needs to be at least python 3.x, and then drop out the failing python version from the matrix. @IAlibay something missing from this is that we want to try and install the latest version of Is this something we want to figure out with some scripting, or do we hard code the version and add bumping it as part of the release checklist? Either way, for testing this PR, I will just hard code it for now |
|
|
Fixes #891
Checklist
newsentryDevelopers certificate of origin