DataType feature (part 1) #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial datafile datatypes Signed-off-by: Mairi Dulaney <[email protected]> * Simplify things, change wording Signed-off-by: Mairi Dulaney <[email protected]> * more Signed-off-by: Mairi Dulaney <[email protected]> * fixups and also redirect from select datatypes if project is approved Signed-off-by: Mairi Dulaney <[email protected]> * Cleanup Signed-off-by: Mairi Dulaney <[email protected]> * fix migrations Signed-off-by: Mairi Dulaney <[email protected]> * Allow file upload to specify datatypes by name or ID Signed-off-by: Mairi Dulaney <[email protected]> * Update tests Signed-off-by: Mairi Dulaney <[email protected]> * Display description Signed-off-by: Mairi Dulaney <[email protected]>
… grandfathering old projects, and some minor tweaks to flow (#996) * Fix deauth hook * Fix deauth hook * Add auto_add_datatypes field to datarequestproject model Signed-off-by: Mairi Dulaney <[email protected]> * remove print Signed-off-by: Mairi Dulaney <[email protected]> * Add new datatypes api endpoint Signed-off-by: Mairi Dulaney <[email protected]> * Better handle names of datatypes and validate them Signed-off-by: Mairi Dulaney <[email protected]> * Disable verifying that file upload includes datatypes Signed-off-by: Mairi Dulaney <[email protected]> * small tweaks Signed-off-by: Mairi Dulaney <[email protected]> * Datatypes test Signed-off-by: Mairi Dulaney <[email protected]> * Move add datatypes view from project creation flow to separate button on project management page Signed-off-by: Mairi Dulaney <[email protected]>
* Fix deauth hook * Fix deauth hook * Add auto_add_datatypes field to datarequestproject model Signed-off-by: Mairi Dulaney <[email protected]> * remove print Signed-off-by: Mairi Dulaney <[email protected]> * Add new datatypes api endpoint Signed-off-by: Mairi Dulaney <[email protected]> * Better handle names of datatypes and validate them Signed-off-by: Mairi Dulaney <[email protected]> * Disable verifying that file upload includes datatypes Signed-off-by: Mairi Dulaney <[email protected]> * small tweaks Signed-off-by: Mairi Dulaney <[email protected]> * Datatypes test Signed-off-by: Mairi Dulaney <[email protected]> * Move add datatypes view from project creation flow to separate button on project management page Signed-off-by: Mairi Dulaney <[email protected]> * Add case insensitive unquieness verification Signed-off-by: Mairi Dulaney <[email protected]>
Projects may have requested vs registered datatypes; this was where we wanted to have a name distinction.
Also updates migrations to match current master branch.
Also rename URLs for DataTypes to remove hyphen
…4-feature-datafile-datatypes
Signed-off-by: Mairi Dulaney <[email protected]>
|
Here's a list of TODO items we still want:
|
madprime
force-pushed
the
201904-feature-datafile-datatypes
branch
from
70505dc
to
6f1f7ce
Compare
…4-feature-datafile-datatypes
madprime
force-pushed
the
201904-feature-datafile-datatypes
branch
from
6f1f7ce
to
c5b761d
Compare
…mans/open-humans into 201904-feature-datafile-datatypes
gedankenstuecke
approved these changes
Apr 15, 2019
This was referenced Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the DataType feature development branch up to date, finalizing "stage 1" of its deployment.
This feature breanch is intended to partly implement #981:
Aspects related to sharing permissions are not part of this PR (i.e. requesting and authorizing data sharing according to DataType).
Also, the feature at this stage does not enforce DataType in uploaded data in any way. Our future goal is to enforce this for future projects while falling back on a default assignment to "grandfather in" existing projects. However, we need to create DataTypes before we can set these defaults.
Testing