fix should serialized #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labordep
reviewed
Mar 8, 2024
| @@ -4,7 +4,7 @@ Extension { #name : #ToElement } | |||
| ToElement >> shouldSerializedChildren [ | |||
| "Toplo elements should not serialize children by default. Manage exeptions in subclasses." | |||
|
|
|||
| ^ false | |||
| ^ (self class == ToElement) | |||
There was a problem hiding this comment.
Why class == ToElement? What it's happen for ToButton class for example? It is a ToElement but class ~= ToElement. It need to save children?
There was a problem hiding this comment.
Ok this is related to your comment below:
"Toplo-Serialization -> If we have a ToElement, it should serialized itt's children. If we have anything with TToPlaceHolder trait it should serialize it's children. Everithing else should not serialize it's children."
Ok so all subclasses of ToElement NOT serialize children.
There was a problem hiding this comment.
Yes, in the examples of Toplo the ToElement is often used as a container. I consider a ToElement to be a container and all subclasses to be a "leaf"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Pyramid alpha5