Add default skills #282
Add default skills #282
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #282 +/- ##
==========================================
+ Coverage 50.35% 52.19% +1.83%
==========================================
Files 119 156 +37
Lines 10077 8281 -1796
==========================================
- Hits 5074 4322 -752
+ Misses 5003 3959 -1044
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
NeonDaniel
force-pushed
the
SKILLS_AddSkillRequirements
branch
from
fbe2616
to
d6d29d0
Compare
| neon-skill-alerts~=1.2 | ||
| ovos-skill-personal | ||
| ovos-skill-naptime | ||
| ovos-skill-date-time>=0.2.2a1 |
There was a problem hiding this comment.
I believe this particular specification will cause pip to pull any published prerelease, not just those of the pinned version
There was a problem hiding this comment.
afaik any a in the dependencies will make it so pip considers alpha dependencies.. i.e. package~=0.1,>=0.0.2a1 would expand to pip install package >=0.1.0,<1.0.0,>=0.0.2a1 which means all alphas are added to candidate versions
There was a problem hiding this comment.
Indeed. What I'm concerned about is that 0.0.3a1 will also be captured. If that's what we want, so be it. I've only recently started to get my head around pip and PEP 440
There was a problem hiding this comment.
Yeah, it's important to make sure no a versions are in any dependencies of stable releases (unless pinned specifically). For this PR, we could either push stable releases all of the added skills now, or include them in a subsequent PR removing alpha versions for all dependencies
There was a problem hiding this comment.
next one, this allows our community to test latest dev branch and report issues before we declare skills stable
#270