Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default skills #282

Merged
merged 4 commits into from
Mar 7, 2023
Merged

Add default skills #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
20c94f1
Add Neon alerts skill
NeonDaniel Feb 15, 2023
d6d29d0
Add all essential skills to dependencies
NeonDaniel Mar 6, 2023
6a5cd40
Pin newer date-time skill to troubleshoot test failure
NeonDaniel Mar 6, 2023
805dcd7
Exclude numpy vulnerability affecting Python3.7 only
NeonDaniel Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/build_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,7 @@ jobs:
- uses: pypa/[email protected]
with:
# Ignore setuptools vulnerability we can't do much about
# Ignore numpy vulnerability affecting latest version for Py3.7
ignore-vulns: |
GHSA-r9hx-vwmv-q579
GHSA-r9hx-vwmv-q579
GHSA-fpfv-jqm9-f5jm
6 changes: 6 additions & 0 deletions requirements/skills-essential.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
ovos-skill-volume~=0.0.1
ovos-skill-fallback-unknown~=0.0.2
ovos-skill-stop~=0.2
neon-skill-alerts~=1.2
ovos-skill-personal
ovos-skill-naptime
ovos-skill-date-time>=0.2.2a1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this particular specification will cause pip to pull any published prerelease, not just those of the pinned version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik any a in the dependencies will make it so pip considers alpha dependencies.. i.e. package~=0.1,>=0.0.2a1 would expand to pip install package >=0.1.0,<1.0.0,>=0.0.2a1 which means all alphas are added to candidate versions

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. What I'm concerned about is that 0.0.3a1 will also be captured. If that's what we want, so be it. I've only recently started to get my head around pip and PEP 440

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's important to make sure no a versions are in any dependencies of stable releases (unless pinned specifically). For this PR, we could either push stable releases all of the added skills now, or include them in a subsequent PR removing alpha versions for all dependencies

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next one, this allows our community to test latest dev branch and report issues before we declare skills stable

ovos-skill-hello-world
ovos-skill-filebrowser