forked from MycroftAI/mycroft-core
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/ovos-gui+ovos-messagebus packages #292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarbasAl
added
refactor
code refactor without functional changes
packaging
dependency updates or packaging changes
labels
Mar 3, 2023
Closed
JarbasAl
force-pushed
the
refactor/split_services
branch
from
April 4, 2023 19:37
ece7b70
to
36ba275
Compare
JarbasAl
force-pushed
the
refactor/split_services
branch
from
April 4, 2023 22:00
48e43ef
to
fce3999
Compare
Merged
JarbasAl
force-pushed
the
refactor/split_services
branch
from
April 5, 2023 20:05
286dcee
to
6fa3310
Compare
This was referenced Apr 7, 2023
JarbasAl
force-pushed
the
refactor/split_services
branch
from
April 29, 2023 21:34
4f61077
to
f0f8433
Compare
Codecov Report
@@ Coverage Diff @@
## dev #292 +/- ##
===========================================
- Coverage 50.35% 18.14% -32.21%
===========================================
Files 119 153 +34
Lines 10077 4678 -5399
===========================================
- Hits 5074 849 -4225
+ Misses 5003 3829 -1174
|
JarbasAl
changed the title
Refactor/split services
Refactor/ovos-gui+ovos-messagebus packages
Apr 29, 2023
no import * move tests to ovos-gui move tests to ovos-gui default mycroft.conf moved to ovos-config package migrate ovos-bus migrate ovos-gui
JarbasAl
force-pushed
the
refactor/split_services
branch
from
April 29, 2023 21:53
4f34d34
to
a62debe
Compare
fix dialog test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mycroft.messagebus.service
-> https://github.com/OpenVoiceOS/ovos-busmycroft.gui
-> https://github.com/OpenVoiceOS/ovos-guiupdates misc imports to use utils and workshop