-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/converse_session #160
Conversation
7f29c2e
to
ccfb6ee
Compare
Would it make sense to have context like: context:
session:
id: This lets the client include any other session data like timestamps, active/inactive, voice vs text, and anything else the client might care about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bus client refactor could probably be a PR on its own to get it in immediately for testing
the session utils are a little different, this also replaces the mycroft.session module so it made sense to do it all together. splitting PRs could be a problem, we will be getting a session object that is not actually managed, the calls to the new util get lang_from_message will also account for this new session object. I don't immediately see an issue there, but i feel this should all be tested together. this PR will need a lot more unittests too |
actually leave this open and I will rebase on top of #292 |
f8cd161
to
b423c9c
Compare
make get_response event based companion PR to OpenVoiceOS/ovos-core#160
b423c9c
to
9605cb1
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #160 +/- ##
==========================================
- Coverage 50.35% 44.28% -6.08%
==========================================
Files 119 13 -106
Lines 10077 1827 -8250
==========================================
- Hits 5074 809 -4265
+ Misses 5003 1018 -3985 ☔ View full report in Codecov by Sentry. |
make get_response event based companion PR to OpenVoiceOS/ovos-core#160
9605cb1
to
0adf031
Compare
adds the concept of Session to converse pipeline, refactors converse and get_response to be event based and per session, requires OpenVoiceOS/OVOS-workshop#68
see session implementation here https://github.com/OpenVoiceOS/ovos-bus-client/blob/dev/ovos_bus_client/session.py
a session can be a user, a client device, or anything else providing utterances to core. immediate applications are in neon multi user setup (each klat user has a session) and in hivemind (each client has a session)