feat/tts_mutator #175
feat/tts_mutator #175
Conversation
add effects to TTS via sox, such as speed and pitch changes ported from https://github.com/HelloChatterbox/text2speech/blob/master/text2speech/modules/__init__.py#L257
JarbasAl
requested review from
ChanceNCounter,
mikejgray,
NeonDaniel and
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #175 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 56
Lines ? 4417
Branches ? 0
=====================================
Hits ? 0
Misses ? 4417
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
it's just wrappers around the sox effects with lots of docstrs, you only need to validate a few of them in practice and confirm kwargs are passed correctly to the subprocess |
There was a problem hiding this comment.
I like this feature in general and it should be a lot of fun for different use cases. However, I'd feel a lot more comfortable approving it if there were some tests. Since we have so many possible interactions with the different sox flags I can imagine a lot of scenarios where they interact poorly.
|
|
||
| def tremolo(self, speed=6.0, depth=40.0): | ||
| """ | ||
| Apply a tremolo (low frequency amplitude modulation) effect to the audio. The tremolo frequency in Hz is giv en by speed, and the depth as a percentage by depth (default 40). |
| def chorus(self, gain_in=0.5, gain_out=0.9, n_voices=3, delays=None, | ||
| decays=None, speeds=None, depths=None, shapes=None): | ||
| """ | ||
| Add a chorus effect to the audio. This can makeasingle vocal sound like a chorus, but can also be applied to instrumentation. |
There was a problem hiding this comment.
Nit: make a single instead of makeasingle
|
replaced by #179 |
add effects to TTS via sox, such as speed and pitch changes
ported from https://github.com/HelloChatterbox/text2speech/blob/master/text2speech/modules/__init__.py#L257
obsoleted by #179