Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

area(MemBlock): remove redundant signals to optimise area #3560

Merged
merged 5 commits into from
Nov 12, 2024
Merged

area(MemBlock): remove redundant signals to optimise area #3560

merged 5 commits into from
Nov 12, 2024
+48 −22

Conversation

jin120811
Copy link
Contributor

@jin120811 jin120811 commented Sep 12, 2024 •
edited
Loading

optimise redundant signals to reduce MemBlock area.

  1. optimise 'exceptionVec', selected by LduCfg or StaCfg;
  2. optimise 'fuType', reassign the value when writeback Rob in pipeline, so no longer saved in LSQ.
  3. optimise 'uop.imm', vaddr is computed in StoreMisalignBuffer and there is no need to store the uop.imm.

@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: a1f28c3

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
a1f28c3 1.865 0.450 2.695 1.186 2.822 2.490 2.401 0.919 1.379 1.454 3.362 2.751 2.418 3.212

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
052738a 2.695 2.401 0.919 1.379 3.212
3e3345d 1.855 0.450 2.695 1.186 2.822 2.490 2.401 0.919 1.379 1.454 3.362 2.751 2.418 3.212
e592da4 0.450 2.695 1.186 2.401 0.919 1.379 1.454 3.362 2.751 3.212
ce54360 1.855 0.450 2.695 1.186 2.822 2.490 2.401 0.919 1.379 1.454 3.362 2.751 2.418 3.212
3019ba8 1.865 0.450 2.695 1.186 2.822 2.490 2.401 0.919 1.379 1.454 3.362 2.751 2.418 3.212
c8c4067 1.865 0.450 2.695 1.186 2.822 2.490 2.401 0.919 1.379 1.454 3.362 2.751 2.418 3.212
976c97c 1.855 0.460 2.695 1.186 2.822 2.490 2.401 0.919 1.379 1.454 3.362 2.751 2.418 3.212
9143e23 0.460 2.695 1.186 2.822 2.490 2.401 0.919 1.379 1.454 3.362 2.751 3.212
b30cb8b 1.865 0.460 2.695 1.186 2.822 2.490 2.401 0.919 1.379 1.454 3.362 2.751 2.418 3.212

@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: d334441

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
d334441 1.865 0.450 2.695 1.186 2.822 2.490 2.401 0.919 1.379 1.454 3.362 2.751 2.418 3.212

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
468d653 0.450 2.695 2.401 1.379 2.751
39db506 2.695 0.919 1.379 3.212
903ff89 1.855 0.450 2.695 1.186 2.822 2.490 2.401 0.919 1.379 1.454 3.362 2.751 2.418 3.212
cfebab2 1.865 0.450 2.695 1.186 2.822 2.490 2.401 0.919 1.379 1.454 3.362 2.751 2.418 3.212
bf652b4 1.855 2.695 1.186 2.822 2.490 0.919 1.379 1.454 3.362 2.418 3.212
f018fe8 1.865 0.450 2.695 1.186 2.822 2.490 2.401 0.919 1.379 1.454 3.362 2.751 2.418 3.212
5334e13 1.855 0.450 2.695 1.186 2.822 2.490 2.401 0.919 1.379 1.454 3.362 2.751 2.418 3.212
6962b4f 1.865 0.450 2.695 1.186 2.822 2.490 2.401 0.919 1.379 1.454 3.362 2.751 2.418 3.212
052738a 1.865 0.450 2.695 1.186 2.822 2.490 2.401 0.919 1.379 1.454 3.362 2.751 2.418 3.212

@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: c70c89a

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
c70c89a 1.934 0.450 2.695 1.194 2.812 2.465 2.400 0.916 1.397 1.626 3.426 2.747 2.429 3.271

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
b9db2c7 0.450 2.695 2.399 1.397 2.761
f3640a5 2.695 1.192 2.812 2.463 0.918 1.397 1.609 3.424 2.429 3.275
e0c1f27 0.450 2.695 2.399 1.397 2.761
8338e67 1.934 0.450 2.695 1.194 2.812 2.465 2.400 0.916 1.397 1.626 3.426 2.747 2.429 3.271
cacfe22 1.934 0.450 2.695 1.194 2.812 2.465 2.400 0.916 1.397 1.626 3.426 2.747 2.429 3.271
556c96d 1.934 0.450 2.695 1.194 2.812 2.465 2.400 0.918 1.397 1.626 3.426 2.747 2.429 3.271
b4d41c1 1.858 0.450 2.695 1.186 2.801 2.445 2.400 0.919 1.397 1.433 3.393 2.747 2.423 3.212
52fc0c9 0.450 2.695 2.400 1.397 2.747
b7dc2d1 1.855 0.450 2.695 1.186 2.832 2.488 2.400 0.919 1.397 1.454 3.415 2.747 2.423 3.212
6a8b2d5 1.855 0.450 2.695 1.186 2.832 2.488 2.400 0.919 1.397 1.454 3.415 2.747 2.423 3.212

@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: b967279

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
b967279 1.936 0.450 2.701 1.198 2.812 2.465 2.403 0.914 1.394 1.626 3.424 2.745 2.428 3.271

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
ea2894c 1.924 0.450 2.701 1.198 2.812 2.465 2.403 0.914 1.394 1.626 3.424 2.745 2.428 3.271
1bc48dd 1.924 0.450 2.701 1.198 2.812 2.465 2.403 0.914 1.394 1.626 3.424 2.745 2.428 3.271
8bc9063 1.936 0.450 2.701 1.198 2.812 2.465 2.403 0.914 1.394 1.626 3.424 2.745 2.428 3.271
9c5487c 1.924 0.450 2.701 1.198 2.812 2.465 2.403 0.914 1.394 1.626 3.424 2.745 2.428 3.271
a32bbcb 1.936 0.450 2.701 1.198 2.812 2.465 2.403 0.914 1.394 1.626 3.424 2.745 2.428 3.271
9abad71 1.924 0.450 2.701 1.198 2.812 2.465 2.403 0.914 1.394 1.626 3.424 2.745 2.428 3.271
be3320d 1.924 0.450 2.701 1.198 2.812 2.465 2.403 0.914 1.394 1.626 3.424 2.745 2.428 3.271
8a4dab4 1.924 0.450 2.701 1.198 2.812 2.465 2.403 0.914 1.394 1.626 3.424 2.745 2.428 3.271
00cefdf 1.924 0.450 2.701 1.198 2.812 2.465 2.404 0.914 1.394 1.626 3.424 2.745 2.428 3.271
b9a37d2 0.450 2.701 2.404 1.394 2.745

@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 0781a55

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
0781a55 1.924 0.450 2.701 1.198 2.812 2.465 2.403 0.914 1.394 1.626 3.424 2.745 2.428 3.271

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
ea2894c 1.924 0.450 2.701 1.198 2.812 2.465 2.403 0.914 1.394 1.626 3.424 2.745 2.428 3.271
1bc48dd 1.924 0.450 2.701 1.198 2.812 2.465 2.403 0.914 1.394 1.626 3.424 2.745 2.428 3.271
8bc9063 1.936 0.450 2.701 1.198 2.812 2.465 2.403 0.914 1.394 1.626 3.424 2.745 2.428 3.271
9c5487c 1.924 0.450 2.701 1.198 2.812 2.465 2.403 0.914 1.394 1.626 3.424 2.745 2.428 3.271
a32bbcb 1.936 0.450 2.701 1.198 2.812 2.465 2.403 0.914 1.394 1.626 3.424 2.745 2.428 3.271
9abad71 1.924 0.450 2.701 1.198 2.812 2.465 2.403 0.914 1.394 1.626 3.424 2.745 2.428 3.271
be3320d 1.924 0.450 2.701 1.198 2.812 2.465 2.403 0.914 1.394 1.626 3.424 2.745 2.428 3.271
8a4dab4 1.924 0.450 2.701 1.198 2.812 2.465 2.403 0.914 1.394 1.626 3.424 2.745 2.428 3.271
00cefdf 1.924 0.450 2.701 1.198 2.812 2.465 2.404 0.914 1.394 1.626 3.424 2.745 2.428 3.271
b9a37d2 0.450 2.701 2.404 1.394 2.745

@jin120811 jin120811 marked this pull request as ready for review October 9, 2024 02:28
@linjuanZ linjuanZ added do not merge Do not merge this pull request area Optimize area comsuption labels Oct 9, 2024
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 0ca72f2

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
0ca72f2 1.917 0.450 2.699 1.190 2.823 2.460 2.395 0.913 1.373 1.611 3.418 2.742 2.420 3.263

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
189d8d0
fab276f 1.917 1.192 2.823 2.460 0.913 1.611 3.418 2.420 3.263
9a07878
c3d62b6 1.928 0.450 2.699 1.190 2.823 2.460 2.395 0.913 1.373 1.611 3.418 2.742 2.420 3.263
a6da536 1.917 0.450 2.699 1.204 2.823 2.460 2.395 0.913 1.373 1.611 3.418 2.742 2.420 3.263

@jin120811 jin120811 changed the title area(MemBlock): optimise redundant signals for PPA area(MemBlock): remove redundant signals to optimise area Oct 30, 2024
@jin120811 jin120811 removed the do not merge Do not merge this pull request label Oct 31, 2024
@jin120811 jin120811 force-pushed the area-kunminghu-V2R2-memblock branch 2 times, most recently from c564390 to 3d094eb Compare November 11, 2024 08:35
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 6f06ab7

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
6f06ab7 1.917 0.450 2.701 1.235 2.891 2.473 2.398 0.916 1.429 1.700 3.470 2.729 2.417 3.280

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
4376b52 0.450 2.701 1.233 2.891 2.473 2.398 0.915 1.429 1.700 3.470 2.729 3.280
68838bf 1.920 0.450 2.701 1.234 2.891 2.473 2.398 0.915 1.429 1.700 3.470 2.729 2.417 3.280
8e8c863 1.937 0.450 2.701 1.248 2.891 2.460 2.400 0.919 1.431 1.685 3.488 2.736 2.418 3.290
521bb21
dd16cea 1.925 0.451 2.701 1.239 2.893 2.460 2.400 0.921 1.428 1.659 3.477 2.733 2.414 3.279

@linjuanZ linjuanZ merged commit e7ab463 into master Nov 12, 2024
9 checks passed
@linjuanZ linjuanZ deleted the area-kunminghu-V2R2-memblock branch November 12, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anzooooo Anzooooo Anzooooo approved these changes

@linjuanZ linjuanZ linjuanZ approved these changes

@weidingliu weidingliu Awaiting requested review from weidingliu weidingliu is a code owner

@good-circle good-circle Awaiting requested review from good-circle good-circle is a code owner

@cz4e cz4e Awaiting requested review from cz4e cz4e is a code owner

Assignees
No one assigned
Labels
area Optimize area comsuption
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jin120811 @XiangShanRobot @linjuanZ @Anzooooo