Add Gecko Addon ID to make storage example compatible with Firefox #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's use env for this instead! |
|
Also, let's make sure the framework itself cleanup these browser specific stuff for chrome target. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an explicit addon ID to the
with-storageexample to make it compatible with Firefox.This PR is connected to PlasmoHQ/storage#12 - the exact reason for this change is added to the updated README there.
Adding this to the manifest will add a warning
Unrecognized manifest key 'browser_specific_settings'.on Chrome as they don't seem to want to just ignore it. The warning has no further result though as the extension will work fine, and it also passes the Chrome WebStore review with this.