Migrate to webextension-polyfill (#11) #12
Conversation
|
Great work overall - since the polyfilled API are all async promise, perhap we can refactor some of the method to be plain async instead of a promise instead. Will take a look deeper in a bit! |
|
Another issue I have with the polyfill is how much weight would it add to the overall bundle, and is there a way to strip out stuffs that's not storage related? :d.... Size ref: I will do another analysis post-bundle with esbuild. Perhaps the bundle mozilla is publishing is unminified. Actually, disregard this. It won't inflate the bundle as it's installed as dependencies. |
src/index.ts
Outdated
| export type StorageWatchEventListener = Parameters< | ||
| typeof chrome.storage.onChanged.addListener | ||
| typeof browser.storage.onChanged.addListener |
There was a problem hiding this comment.
This breaks the const string typing
|
The discussion in here really makes me not want to adopt the polyfill: mozilla/webextension-polyfill#329 The polyfill is also preventing the unit test suite to run. And based on the thread above, it also introduces unwanted bug as well :... On the other hand, without the polyfill, we will have to manually handle the callback xD............................ ARGH |
|
Another problem encountered: the type of the polyfill somehow fuck all the jest mock typing up lol |
This PR migrates the package to the webextension-polyfill package to make it compatible with Firefox.
The package is used to not produce additional overhead by needing to use
if (isChrome) ... else ...for every API call and instead using the unified, promise-based API provided by the polyfill.The storage package API remains unchanged, so packages using this project don't need to update their code to support Firefox. A small info about adding an addon ID for Firefox was added to the README - if merged, this should be added to the docs.
To make the
with-storageexample work for Firefox I created a separate PR at PlasmoHQ/examples#16.Fixes #11