Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report coverage #6

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Aug 1, 2023

  • generate
  • report
  • display

You may have to register at Coveralls https://coveralls.io/github/PrinsFrank/MRTD
or maybe we just need a CI run in the default branch ...

@szepeviktor szepeviktor changed the title Add coverage to PHPUnit [skip ci] Add coverage Aug 1, 2023
.gitignore Show resolved Hide resolved
Comment on lines +1 to +2
# IDE and local environment
/.idea/
Copy link
Contributor Author

@szepeviktor szepeviktor Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep "OS" and "IDE and local environment" patterns on your local machine in user home
git config --global core.excludesFile ~/.gitignore
A single .gitignore file in a project cannot cover every OS, every IDE and every local environment.
Please read https://git-scm.com/docs/gitignore

(these are viktor-invented categories)

Copy link
Contributor Author

@szepeviktor szepeviktor Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will affect every project of yours and put an end to this problem.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by this? The .idea folder is still here, right? And the intention is not that I don't commit them, it's so other peopel don't commit these files. ;)

Copy link
Contributor Author

@szepeviktor szepeviktor Aug 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's so other peopel don't commit these files. ;)

Tough questions. Everyone should have a personal core.excludesFile
The other solution it to have a 30 000 000 000 line long gitignore file covering temporary OS files of a smart microwave oven.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other peopel don't commit these files

That may be called pull request review.

@szepeviktor
Copy link
Contributor Author

Very nice coverage! 🥇
https://coveralls.io/jobs/125871697

@szepeviktor szepeviktor changed the title Add coverage Report coverage Aug 1, 2023
@szepeviktor szepeviktor marked this pull request as ready for review August 1, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants