Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report coverage #6

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Report coverage #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e159d93
Add coverage to PHPUnit [skip ci]
szepeviktor Aug 1, 2023
16315de
Update .gitignore
szepeviktor Aug 1, 2023
3e624d1
Enable coverage upload
szepeviktor Aug 1, 2023
282adb4
Add coverage badge to README
szepeviktor Aug 1, 2023
abb2cb5
Add link on every badge
szepeviktor Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/back-end.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ jobs:
run: |
wget --no-verbose \
"https://github.com/php-coveralls/php-coveralls/releases/download/v2.5.3/php-coveralls.phar"
#php ./php-coveralls.phar --verbose
php ./php-coveralls.phar --verbose

static_analysis:
name: "3️⃣ Static Analysis"
Expand Down
21 changes: 10 additions & 11 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
# Composer
# IDE and local environment
/.idea/
Comment on lines +1 to +2
Copy link
Contributor Author

@szepeviktor szepeviktor Aug 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep "OS" and "IDE and local environment" patterns on your local machine in user home
git config --global core.excludesFile ~/.gitignore
A single .gitignore file in a project cannot cover every OS, every IDE and every local environment.
Please read https://git-scm.com/docs/gitignore

(these are viktor-invented categories)

Copy link
Contributor Author

@szepeviktor szepeviktor Aug 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will affect every project of yours and put an end to this problem.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by this? The .idea folder is still here, right? And the intention is not that I don't commit them, it's so other peopel don't commit these files. ;)

Copy link
Contributor Author

@szepeviktor szepeviktor Aug 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's so other peopel don't commit these files. ;)

Tough questions. Everyone should have a personal core.excludesFile
The other solution it to have a 30 000 000 000 line long gitignore file covering temporary OS files of a smart microwave oven.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other peopel don't commit these files

That may be called pull request review.


# Dependencies
/composer.lock
/vendor/
composer.lock

# CSFixer
.php-cs-fixer.cache
# Library

# PHPUnit
# Tests
/build/
.php-cs-fixer.cache
.phpunit.result.cache
coverage.xml

# JetBrains
.idea

#Gecko driver required for spec update
/drivers
PrinsFrank marked this conversation as resolved.
Show resolved Hide resolved
# Distribution
5 changes: 3 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@

# MRTD - Machine Readable Travel Documents

![GitHub](https://img.shields.io/github/license/prinsfrank/MRTD)
![PHP Version Support](https://img.shields.io/packagist/php-v/prinsfrank/MRTD)
[![License](https://img.shields.io/github/license/prinsfrank/MRTD)](https://github.com/PrinsFrank/MRTD/blob/main/LICENSE)
[![PHP Version Support](https://img.shields.io/packagist/php-v/prinsfrank/MRTD)](https://github.com/PrinsFrank/MRTD/blob/main/composer.json)
[![Coverage](https://coveralls.io/repos/github/PrinsFrank/MRTD/badge.svg)](https://coveralls.io/github/PrinsFrank/MRTD)

Machine Readable Travel Documents are everywhere. They are standardized by ICAO - the International Civil Aviation Organization, a United Nations specialized agency.

Expand Down
5 changes: 5 additions & 0 deletions phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@
<directory>./tests/Feature</directory>
</testsuite>
</testsuites>
<coverage>
<report>
<clover outputFile="build/logs/clover.xml"/>
</report>
</coverage>
<source>
<include>
<directory>./src</directory>
Expand Down