-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test phrases #146
Test phrases #146
Conversation
It's not related to this PR directly but is it possible also to change arguments order of new |
2d0b769
to
98df506
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on the fence here.
Having used tokenize
and compile
to achieve this, I agree that a better way to access phrases would be nice. Accessing the JSON and then falling back to english is a bit much to then also need to send the language code to tokenize
.
That said, compiling the steps as part of this process seems like we're going too far here. Part of me wonders how often this will be used vs just using compile
and tokenize
.
That said, I could see this being helpful if you were trying to reduce a set of steps into a non-one-to-one list of instructions so maybe its worth adding...
I understand your hesitation around the additional |
Can't the tests just call |
98df506
to
45c9ac7
Compare
45c9ac7
to
0d5f0c2
Compare
Omitted any English strings that came in for roundabout exits.
Good point. Done. |
Cool. I think this ready to merge. |
Added a convenience method for tokenizing a phrase, plus tests and test fixtures against that method.
Fixes #143.
/cc @mcwhittemore @lyzidiamond